Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using a drive instead of downloading files #17

Open
brichet opened this issue Dec 14, 2023 · 2 comments
Open

Using a drive instead of downloading files #17

brichet opened this issue Dec 14, 2023 · 2 comments
Labels
enhancement New feature or request

Comments

@brichet
Copy link
Collaborator

brichet commented Dec 14, 2023

Currently the files are downloaded to the file browser, and saved in the web browser storage (indexed DB).

After discussion with @martinRenou, we could probably use a custom drive instead of copying the files to the file browser.

Advantages / drawbacks to be discussed.
@brichet brichet added the enhancement New feature or request label Dec 14, 2023
@jtpio
Copy link
Member

jtpio commented Dec 18, 2023

and saved in the web browser storage (indexed DB).

When used in JupyterLite, right? I suppose because by default JupyterLite saves files in IndexedDB.

This could also be relevant to jupyterlite/jupyterlite#1041, if this behavior gets moved to a drive at some point too.

@martinRenou
Copy link
Member

When used in JupyterLite, right?

Right, if this extension was installed on a classic JupyterLab session, you would download the entire git repo onto the server

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jtpio @martinRenou @brichet