Extension is disabled in Notebook 7

[matthewgasbarro]

Description

When opening a notebook in Notebook 7 (not nbclassic), the git extension is greyed out in the notebook toolbar and the console contains errors that the @jupyterlab/git:clone and @jupyterlab/git:plugin plugins failed to activate

Reproduce

1. Install jupyterlab-git==0.5.0.a.0
2. Open a notebook in Notebook 7
3. Open browser console to see errors
4. See git button in toolbar greyed out

Expected behavior

Either the git extension is supported in Notebook 7 or it should be properly excluded such that there are no console errors and greyed out functionality.

Context

jupyterlab-git==0.5.0.a.0
notebook 7.0.4
jupyter_server 2.9.1

[welcome]

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.

You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

[fcollonval]

Hey @matthewgasbarro thanks for trying this extension with notebook 7.

• The git button is a feature from nbdime; I opened an issue there
• We can certainly makes this extension compatible with notebook 7. My questions are:
  • Where should the git panel (displayed in a sidebar in Lab4) be placed? The tab panel with the filebrowser or a sidebar with the notebook/file document editors?
  • Does the clone button makes also sense in the filebrowser toolbar?

[matthewgasbarro]

Hey @matthewgasbarro thanks for trying this extension with notebook 7.

• The git button is a feature from nbdime; I opened an issue there

• We can certainly makes this extension compatible with notebook 7. My questions are:

  • Where should the git panel (displayed in a sidebar in Lab4) be placed? The tab panel with the filebrowser or a sidebar with the notebook/file document editors?
  • Does the clone button makes also sense in the filebrowser toolbar?

Hi Frederic,

Are the plugins in the console error from nbdime too or the jupyterlab-git extension? Also, I noticed the Git menu in the toolbar just shows Help as an item with a side arrow that does not open. Not sure if that is also a nbdime issue.

If you decide to support Notebook, then I think the sidebar makes sense, similar to the debugger in Notebook 7:

Thanks!
Matt

[fcollonval]

Thanks for the inputs.

Are the plugins in the console error from nbdime too or the jupyterlab-git extension?

No they come from the jupyterlab-git extension.

[matthewgasbarro]

Wanted to follow up on this issue. Is there plans to support Git in Notebook 7? If not, or at least until such feature is ready, can the git and nbdiff toolbar icons be disabled (removed) in Notebook 7. Also the Git menu should be removed. It just contains a Help submenu that has no contents. See image from initial post.