Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make test responses related to groups realistic for respective authenticator class #759

Open
consideRatio opened this issue Sep 3, 2024 · 0 comments

Comments

@consideRatio
Copy link
Member

We currently just inject groups=["group1"] in the user model we mock in tests, but maybe there is a groups property that we can get named something else etc - it could be nice to mock like that instead.

In practice, I see resolving this issue meaning to look into various authenticator classes associated identity providers userinfo responses looking for data associated with group membership of some kind (and then updating tests to include such data in the mocked response).

One could also consider setting a default value, but let's not track that as part of this narrowly scoped issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant