You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
JupyterHub will (not sure how soon) deprecate the Authenticator.db property, because the lifecycle of that property is a problem, and Authenticators and Spawners generally shouldn't ever need access to the JupyterHub db, and certainly shouldn't have access to a shared session on that db.
Make NativeAuthenticator's db session independent of the Hub's internal db session. Creating a new Session against the same database (i.e. starting from db_url instead of db) should be fine, especially since NativeAuthenticator's tables are already independent (related to #28, which I think crosses an internal implementation-detail line).
I think this may need some support from JupyterHub to get the necessary info. Worst case: duplicating db_url config from JupyterHub -> NativeAuthenticator. But since the tables are independent, there's actually no reason other than convenience of configuration for the two to share the same db at all, let alone db session.
Alternative options
Wait for Authenticator.db to be removed, and stop working.
Request new db_session() factory API to create a session on the db that isn't shared with JupyterHub
Who would use this feature?
All future deployments of JupyterHub with NativeAuthenticator
The text was updated successfully, but these errors were encountered:
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
JupyterHub will (not sure how soon) deprecate the
Authenticator.db
property, because the lifecycle of that property is a problem, and Authenticators and Spawners generally shouldn't ever need access to the JupyterHub db, and certainly shouldn't have access to a shared session on that db.xref: jupyterhub/jupyterhub#3700
Proposed change
Make NativeAuthenticator's db session independent of the Hub's internal db session. Creating a new Session against the same database (i.e. starting from db_url instead of db) should be fine, especially since NativeAuthenticator's tables are already independent (related to #28, which I think crosses an internal implementation-detail line).
I think this may need some support from JupyterHub to get the necessary info. Worst case: duplicating db_url config from JupyterHub -> NativeAuthenticator. But since the tables are independent, there's actually no reason other than convenience of configuration for the two to share the same db at all, let alone db session.
Alternative options
db_session()
factory API to create a session on the db that isn't shared with JupyterHubWho would use this feature?
All future deployments of JupyterHub with NativeAuthenticator
The text was updated successfully, but these errors were encountered: