Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to configure SLURM #SBATCH --output #257

Open
t20100 opened this issue Jan 30, 2023 · 1 comment · May be fixed by #258
Open

Add a way to configure SLURM #SBATCH --output #257

t20100 opened this issue Jan 30, 2023 · 1 comment · May be fixed by #258
Labels
enhancement

Comments

@t20100
Copy link
Contributor

t20100 commented Jan 30, 2023 •
edited
Loading

Proposed change

It would be nice to allow the configuration of the --output sbatch parameter the same way as for other parameters.
This would enable customisation of the output file as well as passing /dev/null to silent SLURM output.

Alternative options

Leave it as it is: --output={{homedir}}/jupyterhub_slurmspawner_%j.log

Who would use this feature?

I'm already using a similar feature in jupyterhub_moss, a customized SLURM Spawner (See https://github.com/silx-kit/jupyterhub_moss/blob/fbcf07c7b7198af97e8cd3545458759e5e882b9e/jupyterhub_moss/batch_script.sh#L13), but this requires duplicating the batch_script.

(Optional): Suggest a solution

Add a req_output to SlurmSpawner (see #258).
@welcome
Copy link

welcome bot commented Jan 30, 2023

Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗

If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
welcome
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋

Welcome to the Jupyter community! 🎉

@t20100 t20100 linked a pull request Jan 30, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add SlurmSpawner.req_output t20100/batchspawner
1 participant
@t20100