Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "duplicate notebook" option that keeps the old and new workbooks open #7368

Closed
JasonWeill opened this issue May 13, 2024 · 5 comments · Fixed by #7374
Closed

Add a "duplicate notebook" option that keeps the old and new workbooks open #7368

JasonWeill opened this issue May 13, 2024 · 5 comments · Fixed by #7374

Comments

@JasonWeill
Copy link
Collaborator

The option to duplicate the current notebook doesn't exist any more. I'm guessing "Save as" is the replacement. However, after using this, whilst the newly named notebook pops up in a new tab correctly, the old tab no longer works -- the notebook disappears and the error "kernel unknown" appears. The desired behavior is to have both the new and old notebooks running in separate kernels in separate windows/tabs.

Originally reported by @jph00 in #7041 (comment).

In JupyterLab there is "Duplicate Notebook" option which was recently exposed in command palette and in the tab context menu jupyterlab/jupyterlab#12870. It appears to be an unintentional omission that it was left out in Notebook, it would be a good first issue to restore it by adding docmanager:duplicate to menus and command palette where needed (which might be as simple as just changing a few JSON files, see jupyterlab/jupyterlab#12870)

There is also a button in the tree view:

image

Reply posted by @krassowski in #7041 (comment).

@JasonWeill
Copy link
Collaborator Author

There is already a "duplicate" option in the context menu that appears when I right-click on a file in the tree view.

image

@ai-robert
Copy link

@JasonWeill @jtpio the "duplicate" option being requested there isn't the one pointed out in that screenshot but rather it's missing from the notebook interface. in Jupyter v6 A super common pattern in the notebook interface is to be working on a notebook, and if you want to branch off into different ideas, or keep a cleaner master notebook and then create a duplicate to scratch out some new ideas, is to (within the notebook interface) quickly hit File > "Make a Copy" (sometimes a few times at once) and start picking up right where you left off. Forcing the user to switch to the jupyter hub interface, duplicate, then open the notebook, then switch back... not good... By the way the behavior I'm mentioning for v7 are for the anaconda bundled v7.0.8 and the pypi version 7.2.x. Forgive me if you pushed an update to pypi in the past two weeks I've been under a crunch between my first ticket and this comment

@jtpio
Copy link
Member

jtpio commented Aug 14, 2024

in Jupyter v6 A super common pattern in the notebook interface is to be working on a notebook, and if you want to branch off into different ideas, or keep a cleaner master notebook and then create a duplicate to scratch out some new ideas, is to (within the notebook interface) quickly hit File > "Make a Copy" (sometimes a few times at once) and start picking up right where you left off.

Isn't it what was implemented in #7374 (see screencast on that PR), which should now be available in the latest 7.x releases?

@krassowski
Copy link
Member

Isn't it what was implemented in #7374 (see screencast on that PR),

Yes

which should now be available in the latest 7.x releases?

I think it is not, as that PR was tagged for 7.3 which has not been released yet, right?

@jtpio
Copy link
Member

jtpio commented Aug 14, 2024

I think it is not, as that PR was tagged for 7.3 which has not been released yet, right?

Ah right, I thought it was released in 7.2.0 already.

@ai-robert so this should be released in the upcoming 7.3.0 release. Still need to unblock #7423 to make a new pre-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants