🌠 Support favicon in static builds

Fixes jupyter-book/mystmd#1449
jupyter-book · Oct 3, 2024 · 7770a03 · 7770a03
1 parent 50c6258
commit 7770a03
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/.changeset/new-pens-thank.md b/.changeset/new-pens-thank.md
@@ -0,0 +1,6 @@
+---
+'@myst-theme/article': patch
+'@myst-theme/book': patch
+---
+
+Support favicon in static builds
diff --git a/themes/article/app/root.tsx b/themes/article/app/root.tsx
@@ -26,7 +26,10 @@ export const links: LinksFunction = () => {
   return [
     {
       rel: 'icon',
-      href: '/favicon.ico',
+      href:
+        process.env.MODE === 'static'
+          ? `${process.env.BASE_URL || ''}/favicon.ico`
+          : '/favicon.ico',
     },
     { rel: 'stylesheet', href: tailwind },
     { rel: 'stylesheet', href: thebeCoreCss },

diff --git a/themes/book/app/root.tsx b/themes/book/app/root.tsx
@@ -31,7 +31,10 @@ export const links: LinksFunction = () => {
   return [
     {
       rel: 'icon',
-      href: '/favicon.ico',
+      href:
+        process.env.MODE === 'static'
+          ? `${process.env.BASE_URL || ''}/favicon.ico`
+          : '/favicon.ico',
     },
     { rel: 'stylesheet', href: tailwind },
     { rel: 'stylesheet', href: thebeCoreCss },