Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🦶 Swap html attribute order in footnote header #55

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🦶 Swap html attribute order in footnote header #55

wants to merge 1 commit into from

Conversation

fwkoch
Copy link
Contributor

@fwkoch fwkoch commented Feb 12, 2023

I believe this change is related to syntax-tree/mdast-util-to-hast@b23953d

  • not a functional change, just an attribute order.

@fwkoch fwkoch mentioned this pull request Jan 24, 2024
Open
@fwkoch
Copy link
Contributor Author

fwkoch commented Jan 24, 2024

This change in mdast-util-to-hast broke mystmd tests; however, those were fixed by just doing this text replacement in place during the tests.

Once we land this PR, we can clean up the tests over there: jupyter-book/mystmd#870

@agoose77
Copy link

@fwkoch this can probably merge. Is Rowan the best person to sign off?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fwkoch @agoose77