Add return_is_mutable kwarg to MA.rewrite #312
Merged
+75
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #312 +/- ##
==========================================
- Coverage 90.42% 90.29% -0.14%
==========================================
Files 22 22
Lines 2224 2235 +11
==========================================
+ Hits 2011 2018 +7
- Misses 213 217 +4 ☔ View full report in Codecov by Sentry. |
blegat
reviewed
Nov 15, 2024
| if move_factors_into_sums | ||
| @assert !return_is_mutable |
There was a problem hiding this comment.
Isn't this going to be an issue if JuMP starts using return_is_mutable = true ?
There was a problem hiding this comment.
JuMP uses move_factors_into_sums = false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for jump-dev/JuMP.jl#3882
JuMP needs the ability to tell if it is safe to mutate the returned expression.