Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Handle errors better #178

Open
shubhamsinghmutualmobile opened this issue Nov 28, 2024 · 0 comments
Open

[Android] Handle errors better #178

shubhamsinghmutualmobile opened this issue Nov 28, 2024 · 0 comments

Comments

@shubhamsinghmutualmobile

I see the following crashes in my app's crashlytics window (on Android only):

  1. Screenshot 2024-11-26 at 7 58 56 AM
  2. Screenshot 2024-11-28 at 12 14 27 PM

But since I have wrapped my startDfu() method call inside a try-catch block, I expected this error to be handled and not crash the app. This would've been true if the startDfu future caught the error in the first place, but it seemingly does not.

Ideally, this error should be passed by the library to its own onError callback.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant