-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove all permissions from AndroidManifest.xml to let users choose what they want #163
Comments
I'm struggling with this as well.
...but I can't seem to get the workaround, mentioned above, to work. I then get the following error:
|
I'm not entirely sure about this, but seems like this error is occurring because of some library you might have added that declares a You can see an answer here: https://stackoverflow.com/a/77642329 So please check your Hope this helps somehow |
My bluetooth permissions in the AndroidManifest file are as follows, using tools:node="remove" to remove the existing ones first during the merge. Ensure you add "xmlns:tools="http://schemas.android.com/tools" to the manifest as below: <manifest xmlns:android="http://schemas.android.com/apk/res/android" xmlns:tools="http://schemas.android.com/tools package="...">
|
In the current implementation, the library's
AndroidManifest.xml
contains all permissions required by the library to function properly. That is good, but now the users do not have the flexibility to remove any permissions they do not need. For example, I do not wantFINE_LOCATION
andCOARSE_LOCATION
permissions on Android 12 and above since they are not a hard requirement anymore because I can assert that I don't need the location permissions by usingandroid:usesPermissionFlags="neverForLocation"
.But the library still forces me to have these permissions in my merged manifest. So, if I try to override the permissions by using
tools:maxSdkVersion=30
, it not only does not work but also causes the Play Store console to throw the following issues when I try to upload anAPK
orAAB
:Therefore, I request that we please remove all permissions from the library's AndroidManifest.xml and update the README to instead guide the users to add in only the permissions they require. I am happy to lend a hand and raise a PR if it is acceptable, do let me know.
Temporary Workaround
Just in case someone is trying to find a temporary solution/workaround for this Google Play Store issue, you can follow this solution:
In this case, the
selector
would bedev.steenbakker.nordicdfu
The text was updated successfully, but these errors were encountered: