Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Require unique URL on autofill from URL #1466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Spencerhutch
Copy link

Taking a stab at helping out here.
Let me know if I have missed some conventions.

Closes #1454

@CLAassistant
Copy link

CLAassistant commented Oct 23, 2024

CLA assistant check
All committers have signed the CLA.

@julianpoy
Copy link
Owner

Thanks for this!

Unfortunately I don't want to completely block users from importing things they might have in their collection (but otherwise may have modified!).

If possible, I'd prefer to add a new getSimilarRecipesByURL and query that + display a confirmation alert when the user attempts to import a URL that they've already added to their collection.

@julianpoy
Copy link
Owner

Also, it looks like the original issue is for the WebExtension

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid adding a duplicate recipe
3 participants