-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add separate ES5 & ES6 builds & update package.json #32
Comments
jhildenbiddle
added a commit
to jhildenbiddle/balanced-match
that referenced
this issue
Apr 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As of v2.0.0, many projects will inadvertently bundle ES6 source from
balanced-match
in their ES5 bundles. This is a result of 1)balanced-match
v2.0.0 being written in ES6 but not offering a separate ES5 version as well, and 2) most build processes being configured to ignore files in thenode_modules
folder when transpiring to ES5 (e.g. babel).To address this issue, this library should offer ES5 and ES6 versions (minified and unminified) to accommodate all JavaScript environments. This will allow projects to use
balanced-match
without having to worry about transpilation to ES5. The build process would be trivial (compared to larger apps / libraries) and would likely prevent a lot of frustration.Happy to create a PR with proposed changes.
Thanks!
The text was updated successfully, but these errors were encountered: