From 1cc831ad3bd49eb450e6f13fc05e7e3e49116e65 Mon Sep 17 00:00:00 2001 From: Ian Butterworth Date: Mon, 15 Jan 2024 13:25:08 -0500 Subject: [PATCH 1/7] use windows tar, not git bash one --- src/installer.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/installer.ts b/src/installer.ts index 25aede59..d927b102 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -242,7 +242,8 @@ export async function installJulia(dest: string, versionInfo, version: string, a } } else { // This is the more common path. Using .tar.gz is much faster - await exec.exec('powershell', ['-Command', `tar xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) + // don't use the bit bash provided tar. Issue #205 + await exec.exec('powershell', ['-Command', `"$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) } return dest case 'darwin': From 9d2d860b82c8162620b800764e7c86d78cd0853a Mon Sep 17 00:00:00 2001 From: Ian Butterworth Date: Mon, 15 Jan 2024 13:28:43 -0500 Subject: [PATCH 2/7] correct manual patch --- src/installer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/installer.ts b/src/installer.ts index d927b102..5ecd609d 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -243,7 +243,7 @@ export async function installJulia(dest: string, versionInfo, version: string, a } else { // This is the more common path. Using .tar.gz is much faster // don't use the bit bash provided tar. Issue #205 - await exec.exec('powershell', ['-Command', `"$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) + await exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) } return dest case 'darwin': From 123ab28761d6fa10f0e4b8cd0f3306ba928e2fb8 Mon Sep 17 00:00:00 2001 From: Ian Butterworth Date: Mon, 15 Jan 2024 13:42:58 -0500 Subject: [PATCH 3/7] rebuild --- lib/installer.js | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/lib/installer.js b/lib/installer.js index f1aba02b..55a22fd1 100644 --- a/lib/installer.js +++ b/lib/installer.js @@ -261,7 +261,8 @@ function installJulia(dest, versionInfo, version, arch) { } else { // This is the more common path. Using .tar.gz is much faster - yield exec.exec('powershell', ['-Command', `tar xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]); + // don't use the bit bash provided tar. Issue #205 + yield exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]); } return dest; case 'darwin': From 76b7440f5a8d0ee65a2bcf675215c801ac43fbc3 Mon Sep 17 00:00:00 2001 From: Ian Butterworth Date: Mon, 15 Jan 2024 18:42:00 -0500 Subject: [PATCH 4/7] Update src/installer.ts Co-authored-by: Dilum Aluthge --- src/installer.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/installer.ts b/src/installer.ts index 5ecd609d..bce5621c 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -242,7 +242,7 @@ export async function installJulia(dest: string, versionInfo, version: string, a } } else { // This is the more common path. Using .tar.gz is much faster - // don't use the bit bash provided tar. Issue #205 + // don't use the Git bash provided tar. Issue #205 await exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) } return dest From b8d3686b61deec3816d96f926ff7ace9ccd66feb Mon Sep 17 00:00:00 2001 From: Ian Butterworth Date: Mon, 15 Jan 2024 18:42:23 -0500 Subject: [PATCH 5/7] Update installer.js --- lib/installer.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/installer.js b/lib/installer.js index 55a22fd1..51035eea 100644 --- a/lib/installer.js +++ b/lib/installer.js @@ -261,7 +261,7 @@ function installJulia(dest, versionInfo, version, arch) { } else { // This is the more common path. Using .tar.gz is much faster - // don't use the bit bash provided tar. Issue #205 + // don't use the Git bash provided tar. Issue #205 yield exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]); } return dest; From 78915a854e8e57ae8c283bf841cf8e0cc27aec8f Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Wed, 19 Jun 2024 13:47:25 -0400 Subject: [PATCH 6/7] Include the direct URL of the issue (not just the issue number) --- src/installer.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/installer.ts b/src/installer.ts index 843b53cc..62e79711 100644 --- a/src/installer.ts +++ b/src/installer.ts @@ -264,6 +264,7 @@ export async function installJulia(dest: string, versionInfo, version: string, a } else { // This is the more common path. Using .tar.gz is much faster // don't use the Git bash provided tar. Issue #205 + // https://github.com/julia-actions/setup-julia/issues/205 await exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]) } return dest From 90a5ee7163d1467466976608ba79120854f1b1a1 Mon Sep 17 00:00:00 2001 From: Dilum Aluthge Date: Wed, 19 Jun 2024 16:52:26 -0400 Subject: [PATCH 7/7] npm run build --- lib/installer.js | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/installer.js b/lib/installer.js index a804a296..978f91bb 100644 --- a/lib/installer.js +++ b/lib/installer.js @@ -292,6 +292,7 @@ function installJulia(dest, versionInfo, version, arch) { else { // This is the more common path. Using .tar.gz is much faster // don't use the Git bash provided tar. Issue #205 + // https://github.com/julia-actions/setup-julia/issues/205 yield exec.exec('powershell', ['-Command', `& "$env:WINDIR/System32/tar" xf ${juliaDownloadPath} --strip-components=1 -C ${dest}`]); } return dest;