Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make channel (formerly known as julia-version) optional? #60

Open
davidanthoff opened this issue Apr 14, 2024 · 3 comments
Open

Make channel (formerly known as julia-version) optional? #60

davidanthoff opened this issue Apr 14, 2024 · 3 comments

Comments

@davidanthoff
Copy link

I think that could be optional, with a default value of release?

@DilumAluthge
Copy link
Member

That seems reasonable. Here's one question though: what happens if/when a Julia 2.0 is released (in the distant future, if it ever does happen)? If we default to release, then users will automatically have their workflows start running on Julia 2.0, without any change on their end. Could that be problematic?

Would it make sense to instead default to the 1 channel? And then, if/when Julia 2.0 is released, we would make a breaking release of this action, in which we changed the default value in action.yml from 1 to 2? And then, users of this action won't automatically get upgraded to Julia 2.0 until they merge the Dependabot PR to upgrade to the new breaking release of this action?

@davidanthoff
Copy link
Author

Yeah, it is a trade-off... I think I'm leaning towards either making it mandatory (i.e. leave as is) or making the default release, i.e. your on your own... I think I'm not a huge fan of making 1 the default, don't really have a good reason, but somehow I would then like a mandatory input more ;) I'll post this on the slack channel, maybe others have thoughts.

@DilumAluthge DilumAluthge changed the title Make julia-version optional? Make channel (formerly known as julia-version) optional? Apr 14, 2024
@DilumAluthge
Copy link
Member

We didn't get any further feedback from Slack.

Between keeping it mandatory (leaving the current behavior in place), and defaulting to release, I think I'd prefer we keep it mandatory. I don't love the idea of someone's workflow suddenly switching from Julia 1.x to Julia 2.x without any manual intervention on their part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants