Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENHANCE: Add "claims_supported" part of openid-configuration #332

Open
stevenandres opened this issue Jul 11, 2019 · 5 comments
Open

ENHANCE: Add "claims_supported" part of openid-configuration #332

stevenandres opened this issue Jul 11, 2019 · 5 comments

Comments

@stevenandres
Copy link

Forgive the perhaps obvious question -- trying to interface a working OIDC provider setup with a third-party system that is complaining that the "claims_supported" dictionary is not provided at .well-known/openid-configuration

How do we enable that section? I'm a bit lost in the weeds of the documentation. I don't want to create any custom types, just the standard ones. I was told by this third party that our openid-configuration should look similar to this demo response:

https://abc123-admin.oktapreview.com/.well-known/openid-configuration

@geoff-va
Copy link

geoff-va commented Jul 25, 2019

https://github.com/juanifioren/django-oidc-provider/blob/master/oidc_provider/views.py#L260-L292

Doesn't look like there are currently any mechanisms to support this. It's not part of the current built in response, so would need to be added.

Relevant spec

Note supported_claims is recommended but not a required field.

@stevenandres
Copy link
Author

Correct -- it is not required but I have run into a couple of large third party enterprise systems that are treating it as if it were required (not adhering to standards). In any case, it might be a "nice-to-have" for future revisions of the library. Thanks for the reply!

@geoff-va
Copy link

You bet - does sound like it would be a useful feature to have. Might be worth re-opening this issue or create a new request as an enhancement if you're interested!

@stevenandres
Copy link
Author

Can I just use an issue as an enhancement? Didn't know what was polite way to do it. I'll reopen and see what we get.

@stevenandres stevenandres reopened this Jul 25, 2019
@geoff-va
Copy link

geoff-va commented Jul 25, 2019

yup! You may want to rename it so it's more indicative of the request - something like: Add claims_supported to open-id configuration or whatever you see fit, and then reference pertinent specs in your request.

At some point a maintainer can tag the issue as an Enhancement (See labels tab in the Issues section).

@stevenandres stevenandres changed the title Missing "claims_supported" part of openid-configuration ENHANCE: Add "claims_supported" part of openid-configuration Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants