Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Release RAlt after zippy-chording #1385

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

nightscape
Copy link
Contributor

Describe your changes. Use imperative present tense.

I noticed that after zippy-chording the RAlt Key got stuck until I used another RAlt key.
This PR releases RAlt the same way it is done for the Shift keys.
I added a test by copy & pasting from the Shift tests and modifying it such that it works with the fixed implementation and fails with the old one.

Checklist

  • Add documentation to docs/config.adoc
    • Yes or N/A
  • Add example and basic docs to cfg_samples/kanata.kbd
    • Yes or N/A
  • Update error messages
    • Yes or N/A
  • Added tests, or did manual testing
    • Yes

@jtroo
Copy link
Owner

jtroo commented Nov 26, 2024

Thanks!

@jtroo jtroo merged commit 5b25f3c into jtroo:main Nov 26, 2024
4 checks passed
@nightscape nightscape deleted the zippy-release-ralt branch November 27, 2024 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants