From 0035a687ae6a94771afcab75c1241abacfbd1710 Mon Sep 17 00:00:00 2001
From: Jessica Rairigh <67874354+jfrairigh@users.noreply.github.com>
Date: Tue, 3 Nov 2020 01:35:14 -0600
Subject: [PATCH] [#10580] Student view team page: Loading Indicator for
 loading teammates not centralised (#10790)

* centralised loading indicator on Student view team page #10580

* fixed indidation for solution that centralized Student view team page loading indicator #10790

* fixed indidation for solution that centralized Student view team page loading indicator #10790

* snap updated after fixing indentation for solution in PR 10790

Co-authored-by: Ahmed Bahajjaj <Ahmed_Bahajjaj@u.nus.edu>
---
 ...course-details-page.component.spec.ts.snap | 36 +++++++------------
 ...student-course-details-page.component.html |  4 +--
 2 files changed, 14 insertions(+), 26 deletions(-)

diff --git a/src/web/app/pages-student/student-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap b/src/web/app/pages-student/student-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap
index 3c62b3336bc..e2cf8d81878 100644
--- a/src/web/app/pages-student/student-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap
+++ b/src/web/app/pages-student/student-course-details-page/__snapshots__/student-course-details-page.component.spec.ts.snap
@@ -29,31 +29,21 @@ exports[`StudentCourseDetailsPageComponent should snap when all data are still l
     
     
     
-  </tm-loading-retry><div
-    class="section"
-  >
+  </tm-loading-retry><tm-loading-spinner>
     <div
-      class="row top-padded"
+      class="loading-container"
     >
-      
-      
-      <tm-loading-spinner>
-        <div
-          class="loading-container"
-        >
-          <div
-            class="row spinner-border text-primary"
-            role="status"
-          />
-          <div
-            class="row text-secondary"
-          >
-            Loading...
-          </div>
-        </div>
-      </tm-loading-spinner>
+      <div
+        class="row spinner-border text-primary"
+        role="status"
+      />
+      <div
+        class="row text-secondary"
+      >
+        Loading...
+      </div>
     </div>
-  </div>
+  </tm-loading-spinner>
 </tm-student-course-details-page>
 `;
 
@@ -93,7 +83,6 @@ exports[`StudentCourseDetailsPageComponent should snap with default fields 1`] =
       class="row top-padded"
     >
       
-      
       <div
         class="col-md-10"
       >
@@ -366,7 +355,6 @@ exports[`StudentCourseDetailsPageComponent should snap with populated fields 1`]
           Your teammates:
         </strong>
       </div>
-      
       <div
         class="col-md-10"
       >
diff --git a/src/web/app/pages-student/student-course-details-page/student-course-details-page.component.html b/src/web/app/pages-student/student-course-details-page/student-course-details-page.component.html
index 3edd042144d..709d036602c 100644
--- a/src/web/app/pages-student/student-course-details-page/student-course-details-page.component.html
+++ b/src/web/app/pages-student/student-course-details-page/student-course-details-page.component.html
@@ -85,12 +85,12 @@ <h5 class="d-inline"><strong> Sort By: </strong></h5>
   </div>
 </tm-loading-retry>
 
-<div class="section">
+<div class="section" *tmIsLoading="isLoadingTeammates">
   <div class="row top-padded">
     <div class="col-md-2" *ngIf="teammateProfiles.length">
       <strong>Your teammates:</strong>
     </div>
-    <div class="col-md-10" *tmIsLoading="isLoadingTeammates">
+    <div class="col-md-10">
       <table>
         <tbody>
         <tr *ngFor="let teammateProfile of teammateProfiles; let i = index">