Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimisation #60

Open
AlphaBril opened this issue May 5, 2023 · 1 comment
Open

Optimisation #60

AlphaBril opened this issue May 5, 2023 · 1 comment
Labels
Enhancement New feature or request

Comments

@AlphaBril
Copy link

Just installed, and loving it ! Seriously it rocks good job.

However in VB I got a high cpu usage (40-50%), got to try an install on my laptop to see if it's better. Though a little about it, and wanted to ask if you ever thought to replace in main.c

SDL_Delay(1000 / cfg.targetFPS); by SDL_WaitEvent

to reduce gpu use when we don't use our mouse (knowing that we implement your solution on rice, with a lot of control keys, we don't use the mouse this much).

Also a friend of mine pointed out that the overuse of call on root window may not be for the best. Don't know the options on this, but if we can make use of the GPU, this should optimise and decrement cpu usage again.

Going to fork this and try to implement it later on with a PR, let me now if that sounds right, or if you already inspected those options and they are pointless.

@AlphaBril AlphaBril added the Enhancement New feature or request label May 5, 2023
@jszczerbinsky
Copy link
Owner

Sorry for late resposnse, I didn't have much time lately.

It sounds good, this could improve performance. You can create a PR.

@jszczerbinsky jszczerbinsky added this to the v1.8 milestone Aug 29, 2023
@jszczerbinsky jszczerbinsky removed this from the v2.1.0 milestone Mar 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

2 participants