Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug(scope): inflight 1.0.6 dependency has security issue. #743

Open
1 task done
iChicago opened this issue Jan 25, 2024 · 2 comments
Open
1 task done

Bug(scope): inflight 1.0.6 dependency has security issue. #743

iChicago opened this issue Jan 25, 2024 · 2 comments

Comments

@iChicago
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Which Transloco package(s) are the source of the bug?

Transloco

Is this a regression?

No

Current behavior

We ran a security check for transloco dependency in Angular and we found that it uses inflight 1.0.6 which may lead to Denial of Service (DoS) after memory leakage.

the package inflight in not actively maintained https://www.npmjs.com/package/inflight

Expected behavior

Use alternative package other than inflight or remove it if it is not used.

Please provide a link to a minimal reproduction of the bug, if you won't provide a link the issue won't be handled.

no need

Transloco Config

no need

Please provide the environment you discovered this bug in

Transloco: 6.0.0
Angular: 16
Node: v18.10.0
Package Manager: npm
OS: windows

Browser

All

Additional context

No response

I would like to make a pull request for this bug

No

@abdallahbedir2
Copy link

Yes, please stop using inflight

npm warn deprecated [email protected]: This module is not supported, and leaks memory. Do not use it. Check out lru-cache if you want a good and tested way to coalesce async requests by a key value, which is much more comprehensive and powerful.

@shaharkazaz
Copy link
Collaborator

shaharkazaz commented Sep 12, 2024

@iChicago @abdallahbedir2 This isn't used in production, it's used by the schematics.
This is related to #768, once the schematics are upgraded to ESM with the latest packages this will be resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants