Skip to content
This repository has been archived by the owner on Feb 18, 2024. It is now read-only.

Immediate uninstall if repository casing is mismatched #93

Open
letmaik opened this issue Jul 2, 2016 · 11 comments
Open

Immediate uninstall if repository casing is mismatched #93

letmaik opened this issue Jul 2, 2016 · 11 comments

Comments

@letmaik
Copy link

letmaik commented Jul 2, 2016

If you do jspm install github:alice-and-bob/have-fun where the username is actually called Alice-and-Bob then jspm happily installs the package but one step after doing so removes the "package configuration" again.

@guybedford
Copy link
Member

Is this with jspm 0.16 or jspm 0.17?

@guybedford
Copy link
Member

Also see jspm/jspm-cli#1274.

@letmaik
Copy link
Author

letmaik commented Jul 12, 2016

That's 0.16.

@adamburgess
Copy link

This also happens for .17 (I recently renamed my github and had to do a hard delete and jspm install to fix it)

@guybedford
Copy link
Member

I guess the simple thing to do here is just to add a toLowerCase on the comparison filter in the clean method after installing. But casing in general is still pretty badly handled...

@guybedford
Copy link
Member

Odd I can't seem to recreate this now... I just tried jspm install github:components/classlist.js in both 0.16 and 0.17 and it didn't seem to remove it in either.

@adamburgess
Copy link

My issue was the username -- AdamBurgess to adamburgess.

Also, it was on Windows, ie case insensitive. Not sure if that makes a difference or not. I'll test again shortly

@guybedford
Copy link
Member

Help replicating here would still be appreciated.

@guybedford
Copy link
Member

(or did we fix this casing stuff already?)

@adamburgess
Copy link

adamburgess commented Sep 9, 2016

@guybedford I've just retried this on .17 beta 28 and .16 latest and it's fixed for me, though installing something like AdamBurgess/x is saved as AdamBurgess/x, not the "correct" adamburgess/x

maybe this would be fixed with #54 ?

@guybedford
Copy link
Member

@adamburgess yes casing adjustments should be treated as a redirect actually, which should be relatively straightforward to add.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants