Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up meaningful CI #99

Open
cpovirk opened this issue Oct 7, 2024 · 1 comment
Open

Set up meaningful CI #99

cpovirk opened this issue Oct 7, 2024 · 1 comment

Comments

@cpovirk
Copy link
Collaborator

cpovirk commented Oct 7, 2024

I had said this on cbe846f:

I notice that this commit adds some workflow. It would be neat for us to
adapt those to actually build our annotated JDK, thereby catching at
least simple mistakes. Or maybe we should just delete them. For now, I'm
leaving them in place, even though they fail because the files refer to
JSpecify annotations, which don't exist in this repo.

The fix might be as easy as adding our annotations somewhere (along with appropriate changes to module-info).

Whatever we do, clearly we don't need to run on n different platforms.

@cpovirk
Copy link
Collaborator Author

cpovirk commented Nov 13, 2024

(eisop and typetools do appear to put their annotations into the JDK in some sense during their own CI: https://github.com/typetools/jdk/blob/master/README.md#qualifier-definitions. My efforts in #100 didn't pull that off, but I'd imagine that their lead could be helpful.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant