Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove possible name collisions #43

Open
levino opened this issue Nov 30, 2023 · 2 comments
Open

remove possible name collisions #43

levino opened this issue Nov 30, 2023 · 2 comments
Labels

Comments

@levino
Copy link
Collaborator

levino commented Nov 30, 2023

Currently the registry has some special routes like /interview, /jobs etc. We should host these routes on a different domain or stop using the root for the cv generation (e.g. /{GITHUB_USERNAME}) since if someones username would be "jobs" they just could not create a cv.

@thomasdavis
Copy link
Member

thomasdavis commented May 29, 2024

I'm not sure it's that big of an issue.

Lot's of websites do this e.g. Github, Twitter

Also those pages are re-routed so that only work when in the form of {USERNAME}/interview

@levino
Copy link
Collaborator Author

levino commented May 29, 2024

True, true. But github is in control of the usernames it issues. So nobody can make a user with handle @settings.

Feel free to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants