-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add speak-en-jp to switch language by speak_language rosparam and add test codes. #263
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -75,4 +75,39 @@ | |
:wait wait | ||
:timeout timeout)) | ||
|
||
(defun speak | ||
(speach-string-candidates | ||
&rest args) | ||
"Speak with language selection. | ||
Argument: | ||
speach-string-candidates should be two types: | ||
List of cons of language name and speak-string. For example, '( (\"en\" . \"Hello\") (\"jp\" . \"こんにちわ\") ) | ||
English speak-string. For example, \"Hello\", which is same as '( (\"en\" . \"Hello\") ). | ||
If adequate argument are not specified, english string are input to speak-google. | ||
Speak language name: | ||
Speak language name is switched by 'speak_language' rosparam. | ||
If no such rosparam is specified, speak \"en\". | ||
If users do not use speak-google, speak_language should be related with speak-xx functinos, such as speak-jp and speak-en. Otherwise, speak function invokes error." | ||
;; Convert atom argument to candidate list | ||
(if (stringp speach-string-candidates) | ||
(setq speach-string-candidates (list (cons "en" speach-string-candidates)))) | ||
;; Check speak_language | ||
(let* ((lang (or (ros::get-param "speak_language") "en")) | ||
(speak-string (cdr (assoc lang speach-string-candidates :test #'string=))) | ||
(speak-func | ||
(if (fboundp (eval (read-from-string (format nil "'speak-~A" lang)))) | ||
(eval (read-from-string (format nil "#'speak-~A" lang)))))) | ||
;; Check argument | ||
(unless speak-string | ||
(warn ";; No speach string are specified for ~A from argumenta!! Use english and speak-google!!~%" lang) | ||
(setq speak-string (cdr (assoc "en" speach-string-candidates :test #'string=))) | ||
(setq speak-func #'speak-google)) | ||
;; Check speak-xx function existence. | ||
(unless speak-func | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. if you can not find speak-func, use google, this is why we choose "en" instead of "english" There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This comment is reflected on #383 |
||
(error ";; No such speak function (speak-~A) defined!!~%" lang)) | ||
(warn ";; ~A~%" (list (cadr speak-func) speak-string args)) | ||
;; Speak | ||
(apply speak-func speak-string args) | ||
)) | ||
|
||
(provide :speak) ;; end of speak.l |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for me, using
intern
seems suitable for this case.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This comment is reflected on #383