Skip to content
This repository has been archived by the owner on Aug 31, 2024. It is now read-only.

Update spdy dep #3

Open
rektide opened this issue Sep 26, 2015 · 5 comments
Open

Update spdy dep #3

rektide opened this issue Sep 26, 2015 · 5 comments

Comments

@rektide
Copy link

rektide commented Sep 26, 2015

Would be great to get spdy v2 here; latest is 2.0.5. Currently at "1".

@jonathanong
Copy link
Member

trying to upgrade, but getting a GOAWAY error in the tests. any ideas?

@rektide
Copy link
Author

rektide commented Sep 29, 2015

There's a bunch of api changes, it seems there's a bunch of places where callbacks must now be provided in node-spdy. I've just been monkey-see/monkey-do'ing, & have a WIP branch. There's now a proper exchange of messages again, a message in and a push. It's not refined, nor finished, but at least is on the right track to making everything go again in node-spdy2.

However the acknowledge event is no longer emitted, and I'm not sure what the replacement is going to be. The afterEach is also not properly terminating; apparently the server is not closing down?

@jonathanong
Copy link
Member

thank you! :D i haven't had time to look at it

@jonathanong
Copy link
Member

@rektide any idea what the request and response options are in .push()?

@jonathanong
Copy link
Member

dealing with some stupid GOAWAY error...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants