The "contains" operator needs to work for arrays as well (see how it's implemented in js-data.js ). Also, can you remove your changes to dist/js-data-rethinkdb.js from the PR?

Just to be clear, when you say it should work with arrays, do you mean

1. Check an array property to see if any of the elements in the array contains the string term?
2. Check to see if a string property contains any of the elements in an array term?

I'll need to investigate ReQL to check to see if this is possible. The contains operator in ReQL needs to work in conjunction with the match operator, it seems to me.

http://rethinkdb.com/api/javascript/contains/

I'll close this and create another, without the changes to dist.

Looking at http://www.js-data.io/docs/query-syntax

It seems like option 1 is the requirement.

// Get all users where user.roles contains "admin"
User.filter({
  where: {
    roles: {
      'contains': 'admin'
    }
  }
});

Is there a simple way to tell whether roles (in the example above), is an array property or a string property, since I'll use ReQL operator match for strings and operator contains for arrays.

I'm not for sure on how to implement it, which is why I didn't implement it in the first place.

Ah, ok. It's not worth implementing it for at least the first case (string matching) then? And then add the second case later?

Under normal circumstances, I'd expect these to be 2 different operations (as they are in MongoDB and RethinkDB). In any NoSQL DB, since a column can have any "type", it might prove problematic to determine which type a column is.

Might it make more sense (and more work) to split them into 2 separate ops:

// Get all users where user.roles contains "admin"
User.filter({
  where: {
    roles: {
      'contains': 'admin'
    }
  }
});

And

// Get all users where user.name is like "john"
User.filter({
  where: {
    name: {
      'like': 'john'
    }
  }
});

I'll have to think about it some more. js-data-sql actually has a "like" operator. I want consistency across the store and the adapters.

Grand. Thanks.

—
Johnny H
07971 880871

On Mon, Sep 7, 2015 at 5:29 PM, Jason Dobry [email protected]
wrote:

I'll have to think about it some more. js-data-sql actually has a "like" operator. I want consistency across the store and the adapters.

Reply to this email directly or view it on GitHub:
#11 (comment)