You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Perf is slow and we're rerendering graphs every toggle, which is not ideal.
Renames / deletes require re-rendering, but toggles shouldn't. Plus our mapping functions could be condensed. We could make renames more efficient by directly going through and renaming the mapping, but this adds some more complexity to the code too and isn't a big perf win.
"Perf is probably caused by there being 3 separate mapping functions and them being pretty slow. We can probably do 1 run-through of the data to create mappings, and maybe combine two of them and do filtering better? Not sure" @wustep
"I'm sure we could perform all the data analytics the first time we load in a midi file and store the results in midiFiles, so we're not doing it every time we render a graph. That said, we'd have to change up a lot of end points." @jrg94
The text was updated successfully, but these errors were encountered:
This is kinda a stretch goal, because in practice, users probably shouldn't be toggling graphs back and forth, renaming them a ton, etc., they'll typically make a file configuration and then spend the rest of the time examining the graph.
We could just add a loading spinner for now and call it a day for the sake of priorities
See prior discussion in #25.
Perf is slow and we're rerendering graphs every toggle, which is not ideal.
Renames / deletes require re-rendering, but toggles shouldn't. Plus our mapping functions could be condensed. We could make renames more efficient by directly going through and renaming the mapping, but this adds some more complexity to the code too and isn't a big perf win.
"Perf is probably caused by there being 3 separate mapping functions and them being pretty slow. We can probably do 1 run-through of the data to create mappings, and maybe combine two of them and do filtering better? Not sure" @wustep
"I'm sure we could perform all the data analytics the first time we load in a midi file and store the results in midiFiles, so we're not doing it every time we render a graph. That said, we'd have to change up a lot of end points." @jrg94
The text was updated successfully, but these errors were encountered: