bugfix import() #2076
Open
bugfix import() #2076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 12, 2021
|
@ariya @ljqx could you review? don't know if this is correct: https://github.com/jquery/esprima/pull/2076/files#diff-abe2818e9c29aadf84401cb7ef8286c7cbce9253eba09f6fa52e22ca4e57b17eR1287 first thought parseUnaryExpression is correct, but import('a' + 'b') is valid. but parseExpression is wrong, cause then import('a', 'b') would not fail |
jogibear9988
added a commit
to jogibear9988/esprima-dotnet
that referenced
this pull request
Nov 2, 2021
lahma
pushed a commit
to sebastienros/esprima-dotnet
that referenced
this pull request
Nov 2, 2021
JohnWinston329
added a commit
to JohnWinston329/esprima-dotnet
that referenced
this pull request
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.