Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot create clipping with certain characters in title #53

Open
phubers opened this issue Aug 11, 2022 · 11 comments
Open

Cannot create clipping with certain characters in title #53

phubers opened this issue Aug 11, 2022 · 11 comments

Comments

@phubers
Copy link

phubers commented Aug 11, 2022

When trying to clip from a webpage with "|" in the title, obsidian-clipper does not strip illegal characters from the file name, resulting in an error message in Obsidian (and no clip).

@sometxdude
Copy link

sometxdude commented Aug 14, 2022

I have a similar issue when using {title}. Is there anyway to strip illegal filename characters from {title}?

@cagataykiyici
Copy link

Unfortunately, pipe character ("|") is commonly used in web page titles. Bugfix should also include other forbidden characters which may also be used in page titles.

Therefore, only solution till this is fixed is omiting {title} from config or manualy clip such pages.

@Flashwalker
Copy link

Flashwalker commented Jan 9, 2023

Some characters breaks clipping.
Firstly i thought it was limit for characters amount.
But looks like certain characters breaks clipping.
Looks like the author forgot to url-encode the clipping content

@Flashwalker
Copy link

Flashwalker commented Jan 11, 2023

I made a userscript obsidian-webclip-as-markdown.user.js that clipps ok.
There is no need for remote 3rd party services for this

@iHeadway
Copy link

There is no need for remote 3rd party services for this

It doesn't clip images or I'm doing something wrong.

@Flashwalker
Copy link

There is no need for remote 3rd party services for this

It doesn't clip images or I'm doing something wrong.

give me please the url you are clipping

@iHeadway
Copy link

give me please the url you are clipping

It's a site I tried first: https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade markdownload also has the problem with images there.

@Flashwalker
Copy link

https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade

i see now
I just haven't implemented image clipping yet, it needs to be done.
(Actually it will just by https url)

@Flashwalker
Copy link

Flashwalker commented May 28, 2023

give me please the url you are clipping

It's a site I tried first: https://learn.microsoft.com/en-us/windows/package-manager/winget/upgrade markdownload also has the problem with images there.

Just updated. Now images will be displayed by Obsidian via http url
obsidian-webclip-as-markdown.user.js

@iHeadway
Copy link

@Flashwalker Any chances to have a version without characters limit in the future? 🙂

@Flashwalker
Copy link

@Flashwalker Any chances to have a version without characters limit in the future? slightly_smiling_face

need time to research

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants