Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate / remove hardcoded theme/ directory paths #33

Open
jplatte opened this issue Aug 2, 2024 · 1 comment
Open

Deprecate / remove hardcoded theme/ directory paths #33

jplatte opened this issue Aug 2, 2024 · 1 comment
Labels
A-core Area: Core enhancement New feature or request
Milestone

Comments

@jplatte
Copy link
Owner

jplatte commented Aug 2, 2024

Currently, hinoki hardcodes theme/{assets,templates,sublime} directory paths relative to where it is invoked as places to look at for assets, templates and sublime syntaxes / themes respectively.

I've wanted to allow people who develop a site-specific theme to not need to nest anything into theme if they don't want, and just today realized a nice way of making that happen without weird fallback logic or erroring if both assets and theme/assets exist or whatever: Don't hardcode any paths.

In my mind, this is similar to how i3 / sway don't have any default keybindings. Rather, you start off with an example config and can add / remove things as you see fit. I already applied the same thing to other features, why not do it for input / output directory configuration as well?

This also means the directory layout in the README.md has to be "rebranded" as an example layout.

@jplatte jplatte added enhancement New feature or request A-core Area: Core labels Aug 2, 2024
@jplatte jplatte added this to the v0.2 milestone Aug 2, 2024
@jplatte
Copy link
Owner Author

jplatte commented Aug 23, 2024

The most important bit - allowing configuration - was done in dae47f1.

As of be5cafb, these directories are also resolved relative to the directory that contains the config file.

This is the more important bits for the near future, but for the longer term I'll still consider deprecating and later removing the defaults entirely.

@jplatte jplatte modified the milestones: v0.2, v1.0 Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-core Area: Core enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant