From 1b55191195c4258899a57c40d5ff77ee20820559 Mon Sep 17 00:00:00 2001 From: Alexander Vogt Date: Fri, 28 Jul 2023 14:47:31 +0200 Subject: [PATCH 01/31] tooltip component --- .../src/components/ToolTipComponent.vue | 69 +++++++++++++++++++ 1 file changed, 69 insertions(+) create mode 100644 report-viewer/src/components/ToolTipComponent.vue diff --git a/report-viewer/src/components/ToolTipComponent.vue b/report-viewer/src/components/ToolTipComponent.vue new file mode 100644 index 000000000..8ca1e934d --- /dev/null +++ b/report-viewer/src/components/ToolTipComponent.vue @@ -0,0 +1,69 @@ + + + From 9b9e143c96c391131486afbb9597bf6020edae5c Mon Sep 17 00:00:00 2001 From: Alex | Kronox Date: Sat, 29 Jul 2023 16:28:37 +0200 Subject: [PATCH 02/31] adjustments to tooltip --- .../src/components/ToolTipComponent.vue | 29 +++++++++++++++---- 1 file changed, 23 insertions(+), 6 deletions(-) diff --git a/report-viewer/src/components/ToolTipComponent.vue b/report-viewer/src/components/ToolTipComponent.vue index 8ca1e934d..a6f9c4899 100644 --- a/report-viewer/src/components/ToolTipComponent.vue +++ b/report-viewer/src/components/ToolTipComponent.vue @@ -1,11 +1,13 @@ diff --git a/report-viewer/src/views/ClusterView.vue b/report-viewer/src/views/ClusterView.vue index 82782c485..994b56f57 100644 --- a/report-viewer/src/views/ClusterView.vue +++ b/report-viewer/src/views/ClusterView.vue @@ -15,7 +15,7 @@ - +

Comparisons of Cluster Members:

diff --git a/report-viewer/src/views/OverviewView.vue b/report-viewer/src/views/OverviewView.vue index 13259c6a8..f2ea348b3 100644 --- a/report-viewer/src/views/OverviewView.vue +++ b/report-viewer/src/views/OverviewView.vue @@ -23,9 +23,7 @@ @@ -73,13 +71,11 @@ /> @@ -92,7 +88,7 @@ Date: Sun, 10 Sep 2023 12:15:03 +0200 Subject: [PATCH 12/31] rearange classes --- report-viewer/src/components/ToolTipComponent.vue | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/report-viewer/src/components/ToolTipComponent.vue b/report-viewer/src/components/ToolTipComponent.vue index d7d34a0af..345fd7db7 100644 --- a/report-viewer/src/components/ToolTipComponent.vue +++ b/report-viewer/src/components/ToolTipComponent.vue @@ -1,12 +1,12 @@ From d86abeca8492cad88be4118dd5391f7fce4f703c Mon Sep 17 00:00:00 2001 From: Alex | Kronox Date: Sun, 10 Sep 2023 12:41:58 +0200 Subject: [PATCH 13/31] fix bugs --- .../components/optionsSelectors/MetricSelector.vue | 11 +++++------ report-viewer/src/views/OverviewView.vue | 14 ++------------ 2 files changed, 7 insertions(+), 18 deletions(-) diff --git a/report-viewer/src/components/optionsSelectors/MetricSelector.vue b/report-viewer/src/components/optionsSelectors/MetricSelector.vue index 5e7823eb2..4299cb5e7 100644 --- a/report-viewer/src/components/optionsSelectors/MetricSelector.vue +++ b/report-viewer/src/components/optionsSelectors/MetricSelector.vue @@ -7,6 +7,7 @@ diff --git a/report-viewer/src/views/OverviewView.vue b/report-viewer/src/views/OverviewView.vue index f2ea348b3..9251331cc 100644 --- a/report-viewer/src/views/OverviewView.vue +++ b/report-viewer/src/views/OverviewView.vue @@ -45,7 +45,7 @@ class="mt-2" title="Metric:" @selection-changed=" - (i: number) => (selectedDistributionDiagramMetric = getMetricFromNumber(i)) + (metric: MetricType) => (selectedDistributionDiagramMetric = metric) " /> 1 const submissionPathValue = hasMoreSubmissionPaths ? 'Click More to see all paths' From 32c00c163f2df5c9ee26a3f8e984efe1467b8d26 Mon Sep 17 00:00:00 2001 From: Alex | Kronox Date: Sun, 10 Sep 2023 14:42:55 +0200 Subject: [PATCH 14/31] add tests --- .../components/OptionsSelectorComponent.vue | 0 .../optionsSelectors/MetricSelector.vue | 4 +- .../optionsSelectors/MetricSelector.test.ts | 46 ++++++++++++ .../OptionSelectorComponent.test.ts | 70 +++++++++++++++++++ 4 files changed, 118 insertions(+), 2 deletions(-) delete mode 100644 report-viewer/src/components/OptionsSelectorComponent.vue create mode 100644 report-viewer/tests/unit/components/optionsSelectors/MetricSelector.test.ts create mode 100644 report-viewer/tests/unit/components/optionsSelectors/OptionSelectorComponent.test.ts diff --git a/report-viewer/src/components/OptionsSelectorComponent.vue b/report-viewer/src/components/OptionsSelectorComponent.vue deleted file mode 100644 index e69de29bb..000000000 diff --git a/report-viewer/src/components/optionsSelectors/MetricSelector.vue b/report-viewer/src/components/optionsSelectors/MetricSelector.vue index 4299cb5e7..0ff0d9735 100644 --- a/report-viewer/src/components/optionsSelectors/MetricSelector.vue +++ b/report-viewer/src/components/optionsSelectors/MetricSelector.vue @@ -1,6 +1,6 @@ - - From 3b6050acab93c71f5dbf5939d72c1f8202da0e8e Mon Sep 17 00:00:00 2001 From: Alex | Kronox Date: Mon, 18 Sep 2023 12:33:50 +0200 Subject: [PATCH 31/31] node v18 --- .github/workflows/report-viewer-build-test.yml | 2 +- .github/workflows/report-viewer-dev.yml | 2 +- .github/workflows/report-viewer-e2e.yml | 2 +- .github/workflows/report-viewer-lint.yml | 4 ++-- .github/workflows/report-viewer-prettier.yml | 2 +- .github/workflows/report-viewer-unit.yml | 2 +- .github/workflows/report-viewer.yml | 2 +- report-viewer/package-lock.json | 8 ++++---- report-viewer/package.json | 2 +- 9 files changed, 13 insertions(+), 13 deletions(-) diff --git a/.github/workflows/report-viewer-build-test.yml b/.github/workflows/report-viewer-build-test.yml index 1e51bfefb..aa80c86dd 100644 --- a/.github/workflows/report-viewer-build-test.yml +++ b/.github/workflows/report-viewer-build-test.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Set version of Report Viewer shell: bash diff --git a/.github/workflows/report-viewer-dev.yml b/.github/workflows/report-viewer-dev.yml index e6bf77f37..92fe97407 100644 --- a/.github/workflows/report-viewer-dev.yml +++ b/.github/workflows/report-viewer-dev.yml @@ -18,7 +18,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Set version of Report Viewer shell: bash diff --git a/.github/workflows/report-viewer-e2e.yml b/.github/workflows/report-viewer-e2e.yml index b9ac6354c..9e265b910 100644 --- a/.github/workflows/report-viewer-e2e.yml +++ b/.github/workflows/report-viewer-e2e.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Install and Test 🧪 working-directory: report-viewer diff --git a/.github/workflows/report-viewer-lint.yml b/.github/workflows/report-viewer-lint.yml index 768cdd6c5..924b274e7 100644 --- a/.github/workflows/report-viewer-lint.yml +++ b/.github/workflows/report-viewer-lint.yml @@ -4,7 +4,7 @@ name: Report Viewer ESLint Workflow # Checks linting of report viewer on: workflow_dispatch: push: - path: + paths: - ".github/workflows/report-viewer-lint.yml" - "report-viewer/**" pull_request: @@ -35,7 +35,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Install and Lint 🎨 working-directory: report-viewer diff --git a/.github/workflows/report-viewer-prettier.yml b/.github/workflows/report-viewer-prettier.yml index 2da72eec3..e9933c24e 100644 --- a/.github/workflows/report-viewer-prettier.yml +++ b/.github/workflows/report-viewer-prettier.yml @@ -35,7 +35,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Install and Check 🎨 working-directory: report-viewer diff --git a/.github/workflows/report-viewer-unit.yml b/.github/workflows/report-viewer-unit.yml index 1d3012e4e..48f9082a7 100644 --- a/.github/workflows/report-viewer-unit.yml +++ b/.github/workflows/report-viewer-unit.yml @@ -30,7 +30,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Install and Test 🧪 working-directory: report-viewer diff --git a/.github/workflows/report-viewer.yml b/.github/workflows/report-viewer.yml index eb3642828..624dde7c5 100644 --- a/.github/workflows/report-viewer.yml +++ b/.github/workflows/report-viewer.yml @@ -15,7 +15,7 @@ jobs: - uses: actions/setup-node@v3 with: - node-version: "16" + node-version: "18" - name: Set version of Report Viewer shell: bash diff --git a/report-viewer/package-lock.json b/report-viewer/package-lock.json index 0ea377c82..ea4cca179 100644 --- a/report-viewer/package-lock.json +++ b/report-viewer/package-lock.json @@ -28,7 +28,7 @@ "@playwright/test": "^1.37.1", "@rushstack/eslint-patch": "^1.3.3", "@types/jsdom": "^21.1.2", - "@types/node": "^20.6.0", + "@types/node": "^18.11.9", "@vitejs/plugin-vue": "^4.3.4", "@vue/eslint-config-prettier": "^8.0.0", "@vue/eslint-config-typescript": "^11.0.3", @@ -788,9 +788,9 @@ "dev": true }, "node_modules/@types/node": { - "version": "20.6.0", - "resolved": "https://registry.npmjs.org/@types/node/-/node-20.6.0.tgz", - "integrity": "sha512-najjVq5KN2vsH2U/xyh2opaSEz6cZMR2SetLIlxlj08nOcmPOemJmUK2o4kUzfLqfrWE0PIrNeE16XhYDd3nqg==", + "version": "18.17.17", + "resolved": "https://registry.npmjs.org/@types/node/-/node-18.17.17.tgz", + "integrity": "sha512-cOxcXsQ2sxiwkykdJqvyFS+MLQPLvIdwh5l6gNg8qF6s+C7XSkEWOZjK+XhUZd+mYvHV/180g2cnCcIl4l06Pw==", "dev": true }, "node_modules/@types/semver": { diff --git a/report-viewer/package.json b/report-viewer/package.json index 3650b11e7..1ecabf94d 100644 --- a/report-viewer/package.json +++ b/report-viewer/package.json @@ -37,7 +37,7 @@ "@playwright/test": "^1.37.1", "@rushstack/eslint-patch": "^1.3.3", "@types/jsdom": "^21.1.2", - "@types/node": "^20.6.0", + "@types/node": "^18.11.9", "@vitejs/plugin-vue": "^4.3.4", "@vue/eslint-config-prettier": "^8.0.0", "@vue/eslint-config-typescript": "^11.0.3",