Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ogt_vox : materials are not merged correctly #38

Open
jibjoub opened this issue May 23, 2022 · 1 comment
Open

ogt_vox : materials are not merged correctly #38

jibjoub opened this issue May 23, 2022 · 1 comment

Comments

@jibjoub
Copy link
Contributor

jibjoub commented May 23, 2022

Currently, the materials are well loaded with load_vox_scene but are not merged correctly in ogt_vox_merge_scenes. Thus no materials other than diffuse (default) exist in the merged scene.

@jpaver
Copy link
Owner

jpaver commented Jun 1, 2022

By the way, this PR has been merged: #39 and is a great start.

Currently it finds the palette entry that has the closest color to the one expected and then copies over the material properties for that, but it doesn't really try to match materials at all. This would be problematic If we have palette entries with identical colors but different materials.

To support this properly, we'd have to modify find_exact_color_in_palette and find_closest_color_in_palette to support closest material matching in addition to color matching.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants