You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
- **Coding style**
- [x] OutputPort, don't use magic status strings ==> emulate enums with JS
Done in PR #15.
- [x] Remove global tracing variable
- [x] index.js: The function run2 is definitely too long and too deeply nested. https://github.com/jpaulm/jsfbp/commit/31c69e5f0cf82282ffd390f0c46e71caa8a7a3f0
- [x] Don't write `node_modules/.bin` in package.json. That path is automatically added to PATH when run via `npm run-script`or `npm [command]`. @tlrobinson
- **Bugs**
- [ ] InputPortArray and OutputPortArray: escape regex. Why are regular expressions used anyway?
- [ ] Potential bug: don't compare constructor to Utils.InitConn. This might get tricky if the object is coming from another frame (in the browser), so `Utils.InitConn (frame A) != Utils.InitConn (frame B)`!
- **README**
- [ ] Maybe add a note describing how to install the old Node.js on a per-project Basis.
- [ ] Maybe add a note describing potential errors if a newer Node.js version is used, e.g. https://github.com//pull/17#issuecomment-74336498
- [ ] Update helper function section. `IP.create/createBracket`, `InputPort/OutputPort#openInput/Output[Array]` were moved to `Process.js`.
The text was updated successfully, but these errors were encountered:
Some notes and findings (a.k.a. a TODO list)
- **Coding style** - [x] OutputPort, don't use magic status strings ==> emulate enums with JS
Done in PR #15. - [x] Remove global tracing variable - [x] index.js: The function run2 is definitely too long and too deeply nested. https://github.com/jpaulm/jsfbp/commit/31c69e5f0cf82282ffd390f0c46e71caa8a7a3f0 - [x] Don't write `node_modules/.bin` in package.json. That path is automatically added to PATH when run via `npm run-script`or `npm [command]`. @tlrobinson - **Bugs** - [ ] InputPortArray and OutputPortArray: escape regex. Why are regular expressions used anyway? - [ ] Potential bug: don't compare constructor to Utils.InitConn. This might get tricky if the object is coming from another frame (in the browser), so `Utils.InitConn (frame A) != Utils.InitConn (frame B)`! - **README** - [ ] Maybe add a note describing how to install the old Node.js on a per-project Basis. - [ ] Maybe add a note describing potential errors if a newer Node.js version is used, e.g. https://github.com//pull/17#issuecomment-74336498 - [ ] Update helper function section. `IP.create/createBracket`, `InputPort/OutputPort#openInput/Output[Array]` were moved to `Process.js`.
The text was updated successfully, but these errors were encountered: