Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce “basic” colour theme #328

Merged
merged 3 commits into from
Aug 17, 2024
Merged

Introduce “basic” colour theme #328

merged 3 commits into from
Aug 17, 2024

Conversation

jotaen
Copy link
Owner

@jotaen jotaen commented Aug 17, 2024

Resolves #325.

This PR introduces a new basic colour theme, which is based on 8-bit ANSI colours. It doesn’t override the default text colour, so the colour of black/white text is “responsive” automatically.

@jotaen
Copy link
Owner Author

jotaen commented Aug 17, 2024

@vladdeSV if you like, feel free to check out this PR and the new basic colour theme.

@vladdeSV
Copy link
Contributor

I'll give it a go tomorrow! (busy irl rn)

@vladdeSV
Copy link
Contributor

vladdeSV commented Aug 17, 2024

(lol i managed to compile klog on a vps from my phone while in the passenger seat of a car)

Initial impressions are great! Easily readable in both light and dark themes :)

image

image

image

image

image

Of course, with mismanaged themes it did become a bit hard to read

image

image

@vladdeSV
Copy link
Contributor

Honestly, looks good to me 🙌

I couldn't figure out how to set 8-bit mode, so didn't test that.


Although unrelated to the PR, is it praxis to use British spelling? Mistyped it as "color_scheme", and this is the first time I've noticed to use British

@jotaen
Copy link
Owner Author

jotaen commented Aug 17, 2024

Haha, that’s what I call commitment! 😆 (Glad you didn’t drive, though.) Thanks for checking! It also seems to look good on my end.

I couldn't figure out how to set 8-bit mode, so didn't test that.

The basic theme uses an 8-bit colour palette under the hood (for the 8 basic ANSI colours, in contrast to the extended 256 bit colour map). This is only an unimportant implementation detail, though.

Although unrelated to the PR, is it praxis to use British spelling?

I’m personally used to writing British English, and the entire code base uses British spelling.

@jotaen jotaen merged commit 798c082 into main Aug 17, 2024
8 checks passed
@jotaen jotaen deleted the colour-theme-basic branch August 17, 2024 15:54
@jotaen jotaen mentioned this pull request Aug 17, 2024
jotaen added a commit that referenced this pull request Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide basic 8-bit ANSI colour theme
2 participants