Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make thumbnailImageData optional as it may cause significant performance overhead. #19

Open
joonhocho opened this issue Jan 30, 2017 · 2 comments
Open

Make thumbnailImageData optional as it may cause significant performance overhead. #19

joonhocho opened this issue Jan 30, 2017 · 2 comments
Assignees
@joshuapinter
Labels
Android enhancement help wanted

Comments

@joonhocho
Copy link
Contributor

No description provided.

@joshuapinter
Copy link
Owner

Thanks for bringing this up, @joonhocho!

I tested it against 5000 contacts and it didn't seem to be an issue but it's a good idea to make it optional. I'll do some benchmarking and report back with what I find.

@joshuapinter joshuapinter self-assigned this Jan 30, 2017
@joshuapinter joshuapinter added enhancement Waiting On Maintainers Waiting on the library maintainers. labels Jan 30, 2017
@joshuapinter joshuapinter added help wanted and removed Waiting On Maintainers Waiting on the library maintainers. labels Jan 29, 2018
@paintedbicycle
Copy link
Contributor

I think this is important for Android. I've read in some of the other contacts repos about Android crashing with too much memory usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshuapinter joshuapinter

Labels
Android enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuapinter @paintedbicycle @joonhocho