Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prelogin component for mobile view #150

Open
wants to merge 40 commits into
base: master
Choose a base branch
from
Open

prelogin component for mobile view #150

wants to merge 40 commits into from

Conversation

avinash-mane
Copy link
Contributor

@avinash-mane avinash-mane commented May 20, 2020 •
edited
Loading

  • create pre login panel component
  • test cases

@avinash-mane avinash-mane added the react-frontend For PRs of peerly react app label May 20, 2020
@avinash-mane avinash-mane requested a review from mayuriardad May 20, 2020 14:16
@avinash-mane avinash-mane self-assigned this May 20, 2020
@avinash-mane avinash-mane linked an issue May 20, 2020 that may be closed by this pull request
Add prelogin dashboard with integration of login form layout #148
Open
3 tasks
@avinash-mane avinash-mane force-pushed the feature/react/148/prelogin-dashboard-with-integration-of-login-form branch from 4245ccd to ce80211 Compare May 21, 2020 14:53
@avinash-mane avinash-mane marked this pull request as ready for review May 22, 2020 02:58
@avinash-mane avinash-mane force-pushed the feature/react/148/prelogin-dashboard-with-integration-of-login-form branch from 9c5ae2b to aa64f47 Compare May 22, 2020 09:30
@mayuriardad mayuriardad added the Changes Requested PR needs changes before it can be merged label May 25, 2020
@avinash-mane avinash-mane removed the Changes Requested PR needs changes before it can be merged label May 26, 2020
@mayuriardad mayuriardad requested a review from sahilbhatia May 27, 2020 04:53
sahilbhatia
sahilbhatia suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@sahilbhatia sahilbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Development Guidelilnes not met

@sahilbhatia sahilbhatia added the Changes Requested PR needs changes before it can be merged label May 27, 2020
sahilbhatia
sahilbhatia suggested changes May 27, 2020
View reviewed changes
Copy link
Contributor

@sahilbhatia sahilbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React Development Guidelines not met

@avinash-mane avinash-mane force-pushed the feature/react/148/prelogin-dashboard-with-integration-of-login-form branch from 913769c to 335edb1 Compare May 27, 2020 09:22
@avinash-mane avinash-mane changed the title added image share component for prelogin component prelogin component for mobile view May 27, 2020
mayuriardad
mayuriardad suggested changes Jun 3, 2020
View reviewed changes
Copy link
Contributor

@mayuriardad mayuriardad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mention dependent prs
take rebase with master

react-frontend/src/shared-components/peerly-Logo/LogoComponent.js Outdated

const LogoComponent = () => (
<Col data-testid="peerlyLogoComponent">
<Row>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix grid

@avinash-mane avinash-mane force-pushed the feature/react/148/prelogin-dashboard-with-integration-of-login-form branch from fcb92b0 to f37618f Compare June 8, 2020 10:52
@avinash-mane avinash-mane removed the Changes Requested PR needs changes before it can be merged label Jun 8, 2020
@avinash-mane avinash-mane force-pushed the feature/react/148/prelogin-dashboard-with-integration-of-login-form branch from d172a0c to c371bde Compare June 10, 2020 07:28
sahilbhatia
sahilbhatia suggested changes Jun 10, 2020
View reviewed changes
Copy link
Contributor

@sahilbhatia sahilbhatia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. LoginImageComponent.test.js - has multiple issues
  2. MobileDashboardComponent.js - incorrect file name

react-frontend/src/login/LoginImageComponent.test.js Outdated

import LoginImageComponent from "login/LoginImageComponent";
import { IMG_BASE_PATH } from "constants/appConstants";
import Image from "../../public/assets/images/cat-img.png";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi4630 why do we need this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sahilbhatia for test case of props.when we give size="lg" then render different image therefore
we use this path to check image render correctly or not

@sahilbhatia sahilbhatia added the Changes Requested PR needs changes before it can be merged label Jun 10, 2020
@avinash-mane
Copy link
Contributor Author

avinash-mane commented Jun 10, 2020 •
edited
Loading

  1. LoginImageComponent.test.js - has multiple issues
  2. MobileDashboardComponent.js - incorrect file name

@sahilbhatia mayuri suggest this name

@avinash-mane avinash-mane reopened this Jun 10, 2020
@avinash-mane avinash-mane removed the Changes Requested PR needs changes before it can be merged label Jun 11, 2020
mayuriardad
mayuriardad suggested changes Jun 11, 2020
View reviewed changes
react-frontend/src/login/LoginImageComponent.test.js Outdated
test("render image with correct size", () => {
const { getByAltText } = render(<LoginImageComponent size="lg" />);
const testImage = getByAltText("login image");
expect(testImage.src).toBe("http://localhost/assets/images//cat-img.png");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use IMG_BASE_PATH this here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayuriardad mayuriardad mayuriardad requested changes

@sahilbhatia sahilbhatia sahilbhatia requested changes

Assignees

@mayuriardad mayuriardad

Labels
enhancement New feature or request react-frontend For PRs of peerly react app
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prelogin dashboard with integration of login form layout
5 participants
@avinash-mane @mayuriardad @sahilbhatia @jitendrasbunde @onkar-josh