Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add container component for login API integration #140

Open
14 tasks done
mayuriardad opened this issue May 19, 2020 · 0 comments · May be fixed by #153
Open
14 tasks done

Add container component for login API integration #140

mayuriardad opened this issue May 19, 2020 · 0 comments · May be fixed by #153
Assignees
Labels
enhancement New feature or request react-frontend For PRs of peerly react app

Comments

@mayuriardad
Copy link
Contributor

mayuriardad commented May 19, 2020

  • Create a container component
    which will have the callback function for the google login button

  • The callback function will call Google OAuth API and get the access token

  • Call login API with access token and API helper functions

  • Create an action to set user access token to redux state

  • If the login API call is success dispatch an action to set user's token

  • once this flow is successful use saga generator function to make login API calls

  • Test Case for Saga.

  • Test Case for reducer.

  • Test Case for container.

  • add error handling for login failure.

  • add error handling for closing google login panel.

  • Code guidelines are met

  • PR guidelines are met

  • Test cases added

@mayuriardad mayuriardad added the react-frontend For PRs of peerly react app label May 19, 2020
@sahilbhatia sahilbhatia added the enhancement New feature or request label May 19, 2020
@onkar-josh onkar-josh linked a pull request May 21, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request react-frontend For PRs of peerly react app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants