From 48ba99176f0da30211fd1aa4762f39207fc30871 Mon Sep 17 00:00:00 2001
From: Avinash Mane <avimanepatil@gmail.com>
Date: Tue, 2 Jun 2020 18:17:25 +0530
Subject: [PATCH] resolve comments and added icons core component

---
 .../src/core-components/icon/icons.js         |  1 +
 .../RecognitionCardComponent.js               |  4 +-
 .../RecognitionCardHeaderComponent.js         | 70 ++++++++++---------
 .../RecognitionTextComponent.js               |  4 +-
 .../CoreValueIconComponent.js                 | 15 ----
 .../CoreValueIconComponent.test.js            | 11 ---
 6 files changed, 41 insertions(+), 64 deletions(-)
 create mode 100644 react-frontend/src/core-components/icon/icons.js
 delete mode 100644 react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.js
 delete mode 100644 react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.test.js

diff --git a/react-frontend/src/core-components/icon/icons.js b/react-frontend/src/core-components/icon/icons.js
new file mode 100644
index 000000000..4083f06e0
--- /dev/null
+++ b/react-frontend/src/core-components/icon/icons.js
@@ -0,0 +1 @@
+export { BsCircle } from "react-icons/bs";
diff --git a/react-frontend/src/recognition-list-components/RecognitionCardComponent.js b/react-frontend/src/recognition-list-components/RecognitionCardComponent.js
index 434453ca9..cd8ebcd06 100644
--- a/react-frontend/src/recognition-list-components/RecognitionCardComponent.js
+++ b/react-frontend/src/recognition-list-components/RecognitionCardComponent.js
@@ -4,10 +4,10 @@ import styled from "styled-components";
 
 import { Row, Col } from "core-components/grid/GridComponent";
 import { Card } from "core-components/card/CardComponent";
+import { BsCircle } from "core-components/icon/icons";
 import ImageComponent from "core-components/image/ImageComponent";
 import RecognitionCardHeaderComponent from "recognition-list-components/RecognitionCardHeaderComponent";
 import RecognitionTextComponent from "recognition-list-components/RecognitionTextComponent";
-import CoreValueIconComponent from "shared-components/core-value-icon-components/CoreValueIconComponent";
 import HighFiveComponent from "shared-components/high-five-components/HighFiveComponent";
 
 const giveHighFive = () => {
@@ -71,7 +71,7 @@ const RecognitionCardComponent = ({
                 />
               </ImgD>
               <Col className="d-flex justify-content-center mt-4">
-                <CoreValueIconComponent size="50px" color="red" />
+                <BsCircle size="50px" color="red" />
               </Col>
             </Row>
           </Col>
diff --git a/react-frontend/src/recognition-list-components/RecognitionCardHeaderComponent.js b/react-frontend/src/recognition-list-components/RecognitionCardHeaderComponent.js
index 81afca8ce..0ca7a7505 100644
--- a/react-frontend/src/recognition-list-components/RecognitionCardHeaderComponent.js
+++ b/react-frontend/src/recognition-list-components/RecognitionCardHeaderComponent.js
@@ -2,7 +2,7 @@ import React from "react";
 import PropTypes from "prop-types";
 import styled from "styled-components";
 
-import { Row } from "core-components/grid/GridComponent";
+import { Row, Col } from "core-components/grid/GridComponent";
 import { Form } from "core-components/form/FormComponent";
 import { Button } from "core-components/button/ButtonComponent";
 import ImageComponent from "core-components/image/ImageComponent";
@@ -22,43 +22,45 @@ const RecognitionCardHeaderComponent = ({
 }) => {
   return (
     <Row>
-      <Row className="d-flex justify-content-end">
-        <Button
-          className="bg-white font-weight-bold text-dark btn-outline-light grey"
-          onClick={onclickMenuButton}
-        >
-          ...
-        </Button>
-      </Row>
-      <Row className="d-flex flex-column-left">
-        <Img>
-          <ImageComponent
-            src="https://i.picsum.photos/id/2/200/200.jpg"
-            roundedCircle={true}
-            alt="Profile"
-          />
-        </Img>
-        <Row className="d-flex flex-column text-start ml-4">
-          <Form.Label className="font-weight-bold ">{given_for}</Form.Label>
-          <Row className=" d-sm-block d-xs-block d-md-none">
-            <Row className="d-flex flex-column ml-2">
-              <Form.Label>got a high five for</Form.Label>
-              <Form.Label className="font-weight-bold ml-1">
-                {core_value}
-              </Form.Label>
+      <Col>
+        <Row className="d-flex justify-content-end">
+          <Button
+            className="bg-white font-weight-bold text-dark btn-outline-light grey"
+            onClick={onclickMenuButton}
+          >
+            ...
+          </Button>
+        </Row>
+        <Row className="d-flex flex-column-left">
+          <Img>
+            <ImageComponent
+              src="https://i.picsum.photos/id/2/200/200.jpg"
+              roundedCircle={true}
+              alt="Profile"
+            />
+          </Img>
+          <Row className="d-flex flex-column text-start ml-4">
+            <Form.Label className="font-weight-bold ">{given_for}</Form.Label>
+            <Row className=" d-sm-block d-xs-block d-md-none">
+              <Row className="d-flex flex-column ml-2">
+                <Form.Label>got a high five for</Form.Label>
+                <Form.Label className="font-weight-bold ml-1">
+                  {core_value}
+                </Form.Label>
+              </Row>
             </Row>
-          </Row>
-          <Row className="d-none d-md-block d-{sm,xs}-none">
-            <Row className="d-flex flex-row ml-2">
-              <Form.Label>got a high five for</Form.Label>
-              <Form.Label className="font-weight-bold ml-1">
-                {core_value}
-              </Form.Label>
+            <Row className="d-none d-md-block d-{sm,xs}-none">
+              <Row className="d-flex flex-row ml-2">
+                <Form.Label>got a high five for</Form.Label>
+                <Form.Label className="font-weight-bold ml-1">
+                  {core_value}
+                </Form.Label>
+              </Row>
             </Row>
+            <Form.Label className="text-muted">{given_at}</Form.Label>
           </Row>
-          <Form.Label className="text-muted">{given_at}</Form.Label>
         </Row>
-      </Row>
+      </Col>
     </Row>
   );
 };
diff --git a/react-frontend/src/recognition-list-components/RecognitionTextComponent.js b/react-frontend/src/recognition-list-components/RecognitionTextComponent.js
index 436e1c234..902e80c24 100644
--- a/react-frontend/src/recognition-list-components/RecognitionTextComponent.js
+++ b/react-frontend/src/recognition-list-components/RecognitionTextComponent.js
@@ -25,12 +25,12 @@ const Img = styled.div`
 `;
 
 const RecognitionTextComponent = ({ text, given_by }) => (
-  <Row className="d-flex flex-column">
+  <Row>
     <Border>
       <Legend>“</Legend>
       <Form.Label className="px-2 pb-2 pt-0">{text}</Form.Label>
     </Border>
-    <Row className="d-flex justify-content-end">
+    <Row className="d-flex justify-content-end w-100">
       <Form.Label className="font-weight-bold text-dark">{given_by}</Form.Label>
       <Img>
         <ImageComponent
diff --git a/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.js b/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.js
deleted file mode 100644
index f8cd93ce5..000000000
--- a/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.js
+++ /dev/null
@@ -1,15 +0,0 @@
-import React from "react";
-import PropTypes from "prop-types";
-import { BsCircle } from "react-icons/bs";
-
-const CoreValueIconComponent = (props) => {
-  const { size, color } = props;
-  return <BsCircle size={size} color={color} data-testid="CoreValueIcon" />;
-};
-
-CoreValueIconComponent.propTypes = {
-  size: PropTypes.string.isRequired,
-  color: PropTypes.string.isRequired,
-};
-
-export default CoreValueIconComponent;
diff --git a/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.test.js b/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.test.js
deleted file mode 100644
index edc70c163..000000000
--- a/react-frontend/src/shared-components/core-value-icon-components/CoreValueIconComponent.test.js
+++ /dev/null
@@ -1,11 +0,0 @@
-import React from "react";
-import { render } from "@testing-library/react";
-import CoreValueIconComponent from "./CoreValueIconComponent";
-
-it("renders image component with image", () => {
-  const { getByTestId } = render(
-    <CoreValueIconComponent size="50px" color="red" />
-  );
-  const testIcon = getByTestId("CoreValueIcon");
-  expect(testIcon).toBeInTheDocument();
-});