Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make into a pull request for upstream OpenCV #2

Open
rgap opened this issue Mar 12, 2013 · 2 comments
Open

Make into a pull request for upstream OpenCV #2

rgap opened this issue Mar 12, 2013 · 2 comments

Comments

@rgap
Copy link

rgap commented Mar 12, 2013

Hi
Did you do a pull request for including clahe in Itseez/opencv ?
Please answer.

thanks : )

@joshdoe
Copy link
Owner

joshdoe commented Mar 13, 2013

I haven't done this yet. Two issues:

  1. Shervin Emami made his changes under the LGPL license, while OpenCV code must be under the LGPL. Several ways around this: ask Shervin to make his code BSD, get rid of Shervin's changes and re-implement them from scratch, or make the code part of contrib module.
  2. OpenCV has a higher standard of quality, such as needing testing, and successful compilation across all platforms.
  3. OpenCV's pull request process left a bad taste in my mouth the last time I tried.

You're welcome to help address any of these in any way you can, but I don't have time right now to do so myself, however I'd be happy to accept pull requests that get the code into shape.

@rgap
Copy link
Author

rgap commented Mar 28, 2013

  1. I dont see why to change the LGPL
  2. Ill try to correct Algorithm fails on 64-bit platform #1
  3. Lets try again, maybe there are more mentors these days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants