Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework Tracking Issue: Package currently not working #7

Open
5 tasks
josh-hemphill opened this issue Jul 2, 2021 · 5 comments
Open
5 tasks

Rework Tracking Issue: Package currently not working #7

josh-hemphill opened this issue Jul 2, 2021 · 5 comments
Assignees
Labels
pinned Prevent stale on pinned items

Comments

@josh-hemphill
Copy link
Owner

josh-hemphill commented Jul 2, 2021

Current TODOs:

@josh-hemphill josh-hemphill self-assigned this Jul 2, 2021
@josh-hemphill josh-hemphill pinned this issue Jul 2, 2021
@stale

This comment has been minimized.

@stale stale bot added the stale label Aug 31, 2021
@stale stale bot closed this as completed Sep 7, 2021
@josh-hemphill josh-hemphill added pinned Prevent stale on pinned items and removed stale labels Sep 16, 2021
@josh-hemphill josh-hemphill reopened this Sep 16, 2021
@brunodmn
Copy link

Sry, is the plugin working?
I've just tried, when I build the app, it generates the icons, but with wrong href on dist/index.html

@josh-hemphill
Copy link
Owner Author

Kind of, the html/paths being wrong is a result of the favicons library not exposing any functionality to change or track that part of it.
I haven't touched this in a while, but I'm planning to return to it in the next month or so; I'm going to have to write a separate favicon library, because favicons is really not meant to be used as library even though that's what it's most often used for.

@brunodmn
Copy link

Got it, thank you for answering.

@demc
Copy link

demc commented Aug 1, 2022

Any updates? It appears this library is broken (i.e. the href attributes are wrong upon injection).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pinned Prevent stale on pinned items
Projects
None yet
Development

No branches or pull requests

3 participants