Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue on page /chapter2/ns_code2.html #234

Open
mcastel1 opened this issue Jan 3, 2025 · 3 comments
Open

Issue on page /chapter2/ns_code2.html #234

mcastel1 opened this issue Jan 3, 2025 · 3 comments

Comments

@mcastel1
Copy link

mcastel1 commented Jan 3, 2025

The natural boundary condition for the Poisson-like equation for \phi cannot be satisfied, it is satisfied only to within $O(\Delta t)$, see https://fenicsproject.discourse.group/t/natural-boundary-condition-is-not-satisfied/16606/8?u=mekong .

This should be clarified in the webpage.

@jorgensd
Copy link
Owner

jorgensd commented Jan 3, 2025

I don't think it needs to be added. This tutorial does not have the goal of analysing the complete splitting scheme.
This is the job of: https://computationalphysiology.github.io/oasisx/splitting_schemes.html
where there also are references to several theoretical papers on the proposed method.

You can also find the improved method where one keep an extra term in the equation:
image
image
(the term that is dropped in this tutorial).
In the Navier stokes eq this becomes:
image

Please also note that this is an open source project. If you have a good way of formulating what you want to have on the web-page, you can simply modify the source code and add a pull request.

@mcastel1
Copy link
Author

mcastel1 commented Jan 3, 2025

Do as you wish, but a boundary condition whose residual is huge in the first few steps, and stays large in the following, needs a comment, to the very least. This was confusing not only to me, but also to another colleague of mine.

@mcastel1 mcastel1 closed this as completed Jan 3, 2025
@mcastel1 mcastel1 reopened this Jan 3, 2025
@jorgensd
Copy link
Owner

jorgensd commented Jan 3, 2025

Do as you wish, but a boundary condition whose residual is huge in the first few steps, and stays large in the following, needs a comment, to the very least. This was confusing not only to me, but also to another colleague of mine.

In general, when starting with a zero flow as initial condition, one sees these kind of «spikes» in the pressure/phi, as p_old is 0. This is not unique to this splitting scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants