Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap out Faker for @faker-js/faker #71

Closed
kevin-mitchell opened this issue Feb 3, 2022 · 2 comments
Closed

Swap out Faker for @faker-js/faker #71

kevin-mitchell opened this issue Feb 3, 2022 · 2 comments

Comments

@kevin-mitchell
Copy link

kevin-mitchell commented Feb 3, 2022

note: sorry in advance, this is a copy / paste from the original project. I'm new to the library and am not sure what the history is or future for the project, i.e. if this repo will become the more popular fork, etc, but either way I wanted to raise the issue here as well!

After the "switcheroo" that was pulled with Faker, I imagine that it would be a good idea to switch Faker out for the accepted "official" fork of the original project.

See: https://fakerjs.dev/

My understanding is that the best way to approach this swap would be to wait for the 6.0.0 release of @faker-js/faker (as of this ticket being created the current package is 6.0.0-alpha.5), then "just" swap out the libraries.

In a very quick test I found that it seems pretty simple to swap out "old faker" for "new faker", although I followed these steps https://github.com/faker-js/faker#typescript-support to make TypeScript happy (this may be unnecessary).

@kevin-mitchell
Copy link
Author

FYI @jorgebodega I saw your comment w3tecch#201 and so made this issue here as well :) - let me know if you'd prefer I do this in a different way!

@jorgebodega
Copy link
Owner

Hi! It is okay, don't worry.

This is not an "official' fork, but I was a collaborator on the original one. The changes you can see here on v2 are just some fixes and refactor. After v3, there are some changes just on my own responsability.

As you can see, on v2 faker is on dependencies

"faker": "^5.5.3",

On v3 and after that, faker has been removed from dependencies, so final users don't need to worry about that, they can install the package they want.

Use whatever version you want ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants