Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utilize new optimized APIs #800

Open
rtroberts opened this issue Oct 6, 2024 · 4 comments
Open

Utilize new optimized APIs #800

rtroberts opened this issue Oct 6, 2024 · 4 comments

Comments

@rtroberts
Copy link

BigDebuffs continues to operate via old aura update methods, which are expensive and unnecessary.

Blizzard implemented optimized APIs to interact with changed auras only over two years ago: https://us.forums.blizzard.com/en/wow/t/new-unitaura-processing-optimizations/1205007

It is no longer necessary to iterate through all auras for every UNIT_AURA event. The API provides an additional parameter, which has an attribute containing the changed auras ONLY. Additionally, an extra helper function (AuraUtil.ShouldSkipAuraUpdate()) can be used to return early if no relevant auras are changed.

Another helpful link: https://wowpedia.fandom.com/wiki/UNIT_AURA

@rtroberts
Copy link
Author

I'll try my hand at producing a PR to implement this, but it may take me quite a while to work through LUA dev.

@hqrd
Copy link

hqrd commented Oct 12, 2024

Maybe this could fix the huge CPU usage it has, espacially the more unit it has to track ?

Like reported in #599 #500 #495 #434 #410 #321 #89 #651

@ccowell93
Copy link

Bumping this issue, I have to disable this addon for the time being

@rtroberts
Copy link
Author

Maybe this could fix the huge CPU usage it has, espacially the more unit it has to track ?

Like reported in #599 #500 #495 #434 #410 #321 #89 #651

I think that's likely true.

I haven't had the capacity to work on this myself recently. I hope to find some time over the holidays but we will see.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants