Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation errors shown when closing character sheets #32

Open
Leyaena opened this issue Jan 17, 2023 · 3 comments
Open

Validation errors shown when closing character sheets #32

Leyaena opened this issue Jan 17, 2023 · 3 comments

Comments

@Leyaena
Copy link

Leyaena commented Jan 17, 2023

**Model Validation Errors**

[Actor5e.system]: Model Validation Errors
[CharacterData.spells]: Model Validation Errors
[spell1]: Model Validation Errors
[value]: must be an integer
[spell2]: Model Validation Errors
[value]: must be an integer
[spell3]: Model Validation Errors
[value]: must be an integer

Error gets shown in a toolbar popup once you close the character sheet, as well as the console.
Everything else seems to be working fine, it's just a validation error showing on a big red background once you close the sheet.

Using v1.9.4

@jopeek
Copy link
Owner

jopeek commented Jan 18, 2023

I can't reproduce that. The [spell1..spell3] values aren't part of the sheet either. Feels like another module interfering. Can you try without any other modules or in a clean world? If you figure out which module is causing it, I can check it for compatibility issues and see if I can do something about it in my sheet.

@Leyaena
Copy link
Author

Leyaena commented Jan 20, 2023

I've narrowed it down with an empty world and just one character.

The issue seems to be as soon as you import a character from D&D beyond using MrPrimate's importer tool (https://github.com/mrprimate/ddb-importer), it now shows these model validation errors when interacting with your sheet.

Here's my findings:

  • Empty character, default sheet = no problems
  • Empty character, dndbeyond sheet = no problems
  • DDB imported character, default sheet = no problems
  • DDB imported character, dndbeyond sheet = validation errors

Errors seem to pop up whenever interacting with the sheet. Changes like current HP and spell slots don't seem to persist after closing and reopening the sheet.

It's not just one imported character either, it seems to be happening for every character imported via DDB importer in our current campaign.

Hope that helps narrow things down.
If you need more info, I'm happy to try and provide it.

@jopeek
Copy link
Owner

jopeek commented Jan 20, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants