Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'row' to 'uuid' in the relations schema #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johanjanssens
Copy link
Member

resolve #14

@johanjanssens johanjanssens added this to the 1.0.0 milestone Jul 14, 2016
@johanjanssens
Copy link
Member Author

@ercanozkaya Can you review this? I wanna get rid of the row column name it's too generic. Since tag relations work using uuid I think using uuid as the column name makes a lot more sense.

@johanjanssens johanjanssens changed the title Rename 'row' to 'uuid' in the relations database schema Rename 'row' to 'uuid' in the relations schema Jul 14, 2016
@ercanozkaya
Copy link
Member

@johanjanssens There is one thing that might be a problem in the future. If we add a uuid column to tags table itself as we do/plan to do with every table the joins are not gonna work anymore. In that sense row is a better signal that it's a foreign key no?

@johanjanssens
Copy link
Member Author

@ercanozkaya You could argue that point. In activities we have started to use 'resource_id' instead of row. See: https://github.com/joomlatools/joomlatools-framework-activities/blob/feature/1-denormalization/resources/install/example.sql#L28

The thing with tags is that row makes less sense as we are not using a row id, but a uuid. Not a fan of row, not declarative enough

@ercanozkaya
Copy link
Member

@johanjanssens I'm happy with resource_id. Makes more sense if we are using it in activities too.

@johanjanssens
Copy link
Member Author

@ercanozkaya Can I assign this to you to handle? This change also gonna need to be merged to Kodekit Platform.

@ercanozkaya ercanozkaya modified the milestones: 1.0, 1.2 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename 'row' to 'uuid' in the relations schema
2 participants