Skip to content
This repository has been archived by the owner on Nov 2, 2023. It is now read-only.

Component Selector useless #32

Open
brianteeman opened this issue Feb 9, 2023 · 7 comments
Open

Component Selector useless #32

brianteeman opened this issue Feb 9, 2023 · 7 comments

Comments

@brianteeman
Copy link
Contributor

image

What is this supposed to mean?

Will show the tour only for selected extensions. If used tours won't be displayed at other extensions.

I can write correct text but I dont understand the intended purpose

@chmst
Copy link
Contributor

chmst commented Feb 10, 2023

I think this part is superfluous: If used tours won't be displayed at other extensions.

I understand the second part like this: If this selection is used, the tour will not be displayed on other extensions

@brianteeman
Copy link
Contributor Author

Thats what I guessed as well - in which case it doesnt work

@obuisard
Copy link
Collaborator

We previously had a list of tours showing on toolbars only. Basically, by selecting the components, the tour's list would only get the listed components (or all) in that toolbar. We later decided to make a more general tour button, available at all times. That makes the component selection obsolete.

@obuisard obuisard changed the title Component Selector Component Selector useless Feb 11, 2023
@obuisard
Copy link
Collaborator

The component selector is now used to put forward tours on a specific extension's pages. The tours will show first in the list of tours.

@brianteeman
Copy link
Contributor Author

  1. Not sure I am a fan of moving things around on a menu from a UX perspective.
  2. irrespectiv of that it doesnt appear to work

On a clean install of infra-guided-tour this morning I changed the component option from ALL to NewsFeed on the newsfeed tour.
I then went to the newsfeed component and checked the list of tours on the dropdown. I expected from your description that the newsfeed tour would be at the top but I observed no change at all.

@brianteeman
Copy link
Contributor Author

Retested
On a clean install of infra-guided-tour this morning I changed the component option from ALL to NewsFeed on the newsfeed tour.
I observed that the tour is not present in the module until I am in the newsfeed component. So that part worked.
However it was not at the top it was in its regular order.

There should probably be a column displayed in the tours list view that shows if a tour is set to display on all or some components. Maybe like the modules

@obuisard
Copy link
Collaborator

For now, we show the tours in order of 'ordering'. Let's see what we get from user feedback during beta. I agree changing order of tours may not be the best for UX.

Good idea for the extra column. Let's see what users give as feedback.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants