Complete the checker logic. #4
Conversation
The primary changes are: - The checks are feature complete - The issues are summarized in a text file - The recommendations are also saved in terraform format Incidental changes: - Use common code for API calls - When processing inventory, use the path from the bucket
|
|
||
| for i := range buckets { | ||
| // Get bucket region | ||
| r, err := client.GetBucketLocation(context.TODO(), &s3.GetBucketLocationInput{ | ||
| Bucket: &buckets[i].Name, | ||
| }) | ||
| if err != nil { | ||
| buckets[i].Region = err.Error() | ||
| buckets[i].Region = "Error" //err.Error() |
|
|
||
| writeBasicIssues(issues, identity) | ||
|
|
||
| if api.IsConfigured() { |
There was a problem hiding this comment.
Is it expected by the caller that nothing happens if a token is undefined?
There was a problem hiding this comment.
Yes, it is expected behaviour for now.
| fmt.Fprintf(f, "\nS3 issue check was run as %s\n", identity) | ||
|
|
||
| if len(issues) == 0 { | ||
| fmt.Fprint(f, "\nThere are not issues. You rock!\n") |
There was a problem hiding this comment.
| fmt.Fprint(f, "\nThere are not issues. You rock!\n") | |
| fmt.Fprint(f, "\nThere are no issues. You rock!\n") |
| EncryptionIssue string `json:"encryptionIssue" bson:"encryptionIssue"` | ||
| EncryptionIssueDetails string `json:"encryptionIssueDetails" bson:"encryptionIssueDetails"` | ||
|
|
||
| UsableInventory string `json:"usableInventory" bson:"usableInventory"` |
There was a problem hiding this comment.
I'd like to point out that there are unused bson field tags. They do no harm though other than making me question their utility.
| return | ||
| var ae smithy.APIError | ||
| if errors.As(err, &ae) { | ||
| color.Red("Could not list buckets: %s: %s", ae.ErrorCode(), ae.ErrorMessage()) |
There was a problem hiding this comment.
I believe fmt.Sprintf("%s: %s", e.ErrorCode(), e.ErrorMessage()) is exactly the way smithy-go-codegen implements smithy.APIError interface.
There was a problem hiding this comment.
I'll need to double-check; here I think I did this explicitly because default one looked too verbose.
| } | ||
| defer f.Close() | ||
|
|
||
| fmt.Fprintf(f, "\nS3 issue check was run as %s\n", identity) |
There was a problem hiding this comment.
Ideally, errors shouldn't be ignored here.
The primary changes are:
Incidental changes: