Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML Exercise 1 and 2 Feedback #2

Open
RJP43 opened this issue Oct 4, 2016 · 1 comment
Open

HTML Exercise 1 and 2 Feedback #2

RJP43 opened this issue Oct 4, 2016 · 1 comment

Comments

@RJP43
Copy link
Collaborator

RJP43 commented Oct 4, 2016

@jonhoranic Here are some preliminary comments regarding your webpage on newtfire.org:

You had a couple of hiccups getting your image to be visible on your site. Thank you for sticking around after class on Monday and your email that indicated your process of working that issue out. Remember as you do HTML Exercise 2 to check your permissions, move ALL files from your local Git workspace to GitHub and the PSC, and to logically name your files. Also, thank you for the laugh regarding your "link" testing!

Here are my suggestions to better your webpage:

For HTML Exercise 2 we would like to see you make at least one interior link to a subpage of this main page as well as more external links. You might consider revamping your initial page here to reflect a more professional personal webpage. Perhaps add a picture of yourself and discuss your accomplishments or goals. A personal webpage is a requirement for the Digital Studies Certificate if you are pursuing that.

Experiment with sectioning some of your content in <div> elements and moving them around the page to best compliment the different portions of text off each other. Try moving different content types (text versus images) beside each other on the page and find ways to create smoother transitions between images and text.

As for your CSS styling you have done well to keep things simple, but as it becomes more complicated consider using comment tags (/*comment in here*/) to organize the different sections of styling that go with different pages. The black background certainly makes your heading pop; however, consider ease of reading when choosing site colors. Is it easy on the eyes to read bright colors on a black background?

It looks like you may have some messy file extensions on your files. Notice your index page has multiple file extensions: index.html.xhtml to resolve this open the file in oXygen. When you go to save the file select All files in the file type and just put the .html extension on your file name "index" This should fix the issue.

Check CourseWeb for your grade on this assignment. @ebeshero and I look forward to seeing how you change your page for Exercise 2!

@RJP43 RJP43 changed the title HTML Exercise 1 Feedback HTML Exercise 1 and 2 Feedback Dec 20, 2016
@RJP43
Copy link
Collaborator Author

RJP43 commented Dec 20, 2016

@jonhoranic I really like that you are using your newtfire web space to display your digital work for the H.E.L. course. Your javascript works great and the CSS on the page looks good. As your digital portfolio continues to grow you might make you index page a more general page about yourself that points to your digital scholarship on a subsequent page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant