Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What is the plan for 2.13.0? #452

Open
jcoyne opened this issue Feb 25, 2021 · 23 comments
Open

What is the plan for 2.13.0? #452

jcoyne opened this issue Feb 25, 2021 · 23 comments

Comments

@jcoyne
Copy link
Contributor

jcoyne commented Feb 25, 2021

It looks like there have been a number of fantastic changes since 2.12.0 was released (about 14 months ago). It would be w if a new version was released. Are there any blockers for that?

@sdrioux
Copy link

sdrioux commented Mar 29, 2021

Bump. Can we get a new version?

@asabourin
Copy link

asabourin commented Jun 29, 2021

Would also help us to get a new version released, particularly with the relaxed rake version dependency :-)

@verenion
Copy link

This is becoming a nightmare for us at the moment. If we could get a release simply to fix the rake issue, that would be great.

kyrylo added a commit to airbrake/airbrake that referenced this issue Sep 22, 2021
We have to do that so that we can resolve the rake version problem (sneakers
wants an older version of rake, other gems want newer). This was fixed on their
`master`.

Likely the issue to track: jondot/sneakers#452
@thisismydesign
Copy link

You can do gem 'sneakers', github: 'jondot/sneakers' until a new release

@jcoyne
Copy link
Contributor Author

jcoyne commented Sep 27, 2021

@thisismydesign that works, but it doesn't have any semver conventions, so if you update your bundle and a breaking change is merged you maybe caught off guard.

@pirj
Copy link

pirj commented Jan 26, 2022

so if you update your bundle and a breaking change is merged you maybe caught off guard

Can be pinned to a ref:

gem 'sneakers', github: 'jondot/sneakers', ref: '31d0cb25'

@h0jeZvgoxFepBQ2C
Copy link

Hm, is there really not a way to create a new release? the last one is from 2019? Do you need more maintainers for this project?

@h0jeZvgoxFepBQ2C
Copy link

ping @gabrieljoelc

@gabrieljoelc
Copy link
Collaborator

@h0jeZvgoxFepBQ2C the contributors (including myself) have been dormant for a while unfortunately. We likely could use more contributors who are still actively using Ruby. However, I don't own the project so not sure I can make the final call on a contributor.

I will try to refresh myself on the release this weekend

@h0jeZvgoxFepBQ2C
Copy link

Ok this sounds great, thank you so much!

@michaelklishin
Copy link
Collaborator

I would produce a release but not sure if I have the permissions both on GH and RubyGems

@gabrieljoelc
Copy link
Collaborator

@michaelklishin not sure I do either. I couldn't remember if it was in the CI or not but I guess it's not. :(

@michaelklishin
Copy link
Collaborator

My best suggestion would be to push this repo to a new one under the ruby-amqp GitHub org but it won't help us with RubyGems access for releases.

@michaelklishin
Copy link
Collaborator

@jondot can you please add me as a maintainer on RubyGems and perhaps transfer the repo to github.com/ruby-amqp? 🙏

@lucaong
Copy link
Contributor

lucaong commented Nov 15, 2023

Any update on this? I completely understand that this requires assigning maintainer rights, and that without it there is no way to proceed, therefore I am sorry to bump this thread up again. Just doing it because by now the Rake version dependency is making Sneakers incompatible with many other popular gems (like http, for example).

@simi
Copy link

simi commented Jan 3, 2024

Any news on this? This projects definitely needs new release. I'm happy to help if welcomed.

@dwkoogt
Copy link
Contributor

dwkoogt commented Jun 26, 2024

Any news? I see @jondot and @gabrieljoelc as admins on rubygems. Maybe add @michaelklishin on there?

@simi
Copy link

simi commented Jun 26, 2024

Any news? I see @jondot and @gabrieljoelc as admins on rubygems. Maybe add @michaelklishin on there?

I did my best to move forward with Sneakers (in recent few months) and I think we should consider it abandoned with no way to continue for now. We can try to plan fork and rename.

@michaelklishin
Copy link
Collaborator

I agree, the original author has moved on.

I can set up a repo under ruby-amqp for a new project based on the current state of Sneakers. I don't have a better name than "kicks", though.

@michaelklishin
Copy link
Collaborator

michaelklishin commented Jun 26, 2024

Here's a new blank repo https://github.com/ruby-amqp/kicks (since the name is a decent pun on the original one and it is not taken on RubyGems). @simi was invited to it.

We can do the following to proceed, since the MIT license permits us to do so:

  • Push this repo as is there
  • Update the README to credit @jondot for the original Sneakers project
  • Ask authors of open PRs to re-submit them there
  • Bump the major version to indicate the shift to the new repo with a new set of maintainers.
  • Update this repo's README to reflect the move to the new home
  • Release the current state of the project without renaming anything as kicks X.0
  • If we choose to — and I don't think we have to or should — we can rename the modules and so on to Kicks

I do not volunteer to be a maintainer but since I work on RabbitMQ and (as time permits) Bunny, you can be sure that I at least will be around to grant permissions to those willing to maintain Kicks.

I will also be around to not allow for any decisions that Team RabbitMQ would find questionable in such a library/tool. Or at least serve as a "litmus test" for ideas and changes.

If you want to be on the Kicks maintainers team (for real, maintaining OSS software can be nerve wrecking, truly thankless and time consuming), just start a Discussion in that repo.

HTH.

@simi
Copy link

simi commented Jun 26, 2024

@michaelklishin great, I'll reopen some crucial PRs in there and let's aim to release new version soon. See you in there!

@michaelklishin
Copy link
Collaborator

@simi awesome! I'm working on some README updates as outlined above.

michaelklishin added a commit that referenced this issue Jun 26, 2024
We are very thankful to @jondot for developing and open
sourcing Sneakers 🙏 

and simply want that work to continue being developed and
used.
@michaelklishin
Copy link
Collaborator

Discussions are now enabled in ruby-amqp/kicks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests