Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardware back button does not close the gallery photo viewer #6

Open
jjexperto opened this issue Jun 16, 2017 · 5 comments
Open

Hardware back button does not close the gallery photo viewer #6

jjexperto opened this issue Jun 16, 2017 · 5 comments
Assignees
Labels

Comments

@jjexperto
Copy link

Hello,
I installed your component and it is working great, but i have one problem, the hardware back button does not close the Photo viewer. Do you have the solution for this or did i missed one step in the installation guide.
Greetings

@jonathanheilmann
Copy link
Owner

Hi, you didn't miss anything. If the hardware back button is not working, it's related to a missing implementation.
I'm going to implement this in two weeks. If you can't wait for it you may try to do it on your own. It requires to add an event listener on ngInit and removing the listener on ngDestroy. A listener like this is required: https://stackoverflow.com/questions/18997793/javascript-backbutton-event-listener-overrides-the-android-device-back-button closing mfp on listener call

@jonathanheilmann
Copy link
Owner

Solving this issue isn't as easy as I thought. I'm still working on it.

@jonathanheilmann
Copy link
Owner

I've managed to create a solution. I'd appreciate if you could run

npm install heilbaum-ionic-photoswipe@beta

and leave some feedback if everything is working as expected or if not.

@ASHFAQPATWARI
Copy link

Is this issue resolved ?

@niravparsana94
Copy link

Hi @jjexperto ,
Can you please tell how to use this photoswipe from scratch?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants